Skip to content

Translate Code Splitting - #21

Merged
azizaismayilova merged 3 commits into
masterfrom
translate-code-splitting
Feb 20, 2019
Merged

Translate Code Splitting#21
azizaismayilova merged 3 commits into
masterfrom
translate-code-splitting

Conversation

@GasimGasimzada

@GasimGasimzadaGasimGasimzada commented Feb 14, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Bundling
  • Code Splitting
  • Route based splitting
  • Named Exports

@GasimGasimzadaGasimGasimzada changed the title WIP: Translate Code SplittingTranslate Code SplittingFeb 14, 2019
@tesseralis

tesseralis commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

@Haqverdi

Haqverdi commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

Yes, I checked the main parts, everything seems to be okay, unfortunately we are 2-3 people for now, therefore have to do so in order to translate as soon as possible.

@azizaismayilova

azizaismayilova commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@tesseralis I have checked the content and there are some issues (typos, grammar issues). I will push them, once they are all fixed.

@Haqverdi

Haqverdi commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

I think we should translate the main part as soon as possible, then correct the shortcomings

@azizaismayilova
azizaismayilova merged commit bef5659 into masterFeb 20, 2019
@netlify

netlifyBot commented Feb 20, 2019

Copy link
Copy Markdown

Deploy preview for az-reactjs ready!

Built with commit 54250e5

https://deploy-preview-21--az-reactjs.netlify.com

@GasimGasimzada
GasimGasimzada deleted the translate-code-splitting branch February 22, 2019 23:11
@tesseralistesseralis mentioned this pull request Oct 14, 2019
Closed
99 tasks
@GasimGasimzadaGasimGasimzada added this to the Advanced Guides milestone Oct 14, 2019
@GasimGasimzadaGasimGasimzada added the new page Translate a new page label Oct 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HaqverdiHaqverdiHaqverdi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GasimGasimzadaGasimGasimzada

@azizaismayilovaazizaismayilova

Labels

new pageTranslate a new page

Projects

None yet

Milestone

Advanced Guides

Development

Successfully merging this pull request may close these issues.

4 participants

@GasimGasimzada@tesseralis@Haqverdi@azizaismayilova