Skip to content

Components and Props translation - #10

Merged
alejandronanez merged 11 commits into
reactjs:masterfrom
EzequielMonforte:translate-components-props
Feb 2, 2019
Merged

Components and Props translation#10
alejandronanez merged 11 commits into
reactjs:masterfrom
EzequielMonforte:translate-components-props

Conversation

@EzequielMonforte

@EzequielMonforteEzequielMonforte commented Jan 31, 2019•
edited by alejandronanez
Loading

Copy link
Copy Markdown
Contributor

Components and props
Related to #4

@EzequielMonforteEzequielMonforte changed the title WIP Components and PropsWIP Components and Props translationJan 31, 2019
@tesseralistesseralis mentioned this pull request Jan 31, 2019
Closed
@EzequielMonforteEzequielMonforte changed the title WIP Components and Props translationComponents and Props translationJan 31, 2019
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
gariasf
gariasf reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md
alejandronanez
alejandronanez reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
carburo
carburo reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
carburo
carburo reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
carburo
carburo reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
ricglz
ricglz reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md
ricglz
ricglz reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
ricglz
ricglz reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
@EzequielMonforte

EzequielMonforte commented Feb 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Corrections applied

alejandronanez
alejandronanez reviewed Feb 1, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EzequielMonforte, I left some comments that are worth addressing before merging this PR.

Thanks!

Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
alejandronanez
alejandronanez approved these changes Feb 2, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EzequielMonforte, thanks for addressing all the comments in record time!

This is looking good - thanks for contributing!

@alejandronanez
alejandronanez merged commit a4efd8e into reactjs:masterFeb 2, 2019
@EzequielMonforte
EzequielMonforte deleted the translate-components-props branch February 2, 2019 00:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo left review comments
@dmoralesmdmoralesmAwaiting requested review from dmoralesm
+4 more reviewers
@sergiodxasergiodxasergiodxa left review comments
@gariasfgariasfgariasf left review comments
@ricglzricglzricglz left review comments
@alejandronanezalejandronanezalejandronanez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EzequielMonforte@alejandronanez@sergiodxa@carburo@gariasf@ricglz