Skip to content

Translating react dom server - #110

Merged
alejandronanez merged 3 commits into
reactjs:masterfrom
devrchancay:master
Feb 7, 2019
Merged

Translating react dom server#110
alejandronanez merged 3 commits into
reactjs:masterfrom
devrchancay:master

Conversation

@devrchancay

@devrchancaydevrchancay commented Feb 6, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Translation of API Reference for ReactDOM

Related:Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft
  • Check translation
  • Check grammar and orthography
  • Submit final

icarlossz
icarlossz suggested changes Feb 6, 2019
View reviewed changes

@icarlosszicarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments.

Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md Outdated
Comment threadcontent/docs/reference-react-dom-server.md
@devrchancay

devrchancay commented Feb 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@icarlossz thanks for the observations.

done!

alejandronanez
alejandronanez approved these changes Feb 7, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devrchancay, thanks for your contribution - and congratulations on your first PR!

This is looking good! I'm gonna merge it right away!

Thanks @icarlossz for the review :)

@alejandronanez
alejandronanez merged commit 474ac89 into reactjs:masterFeb 7, 2019
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@icarlosszicarlosszicarlossz requested changes
@alejandronanezalejandronanezalejandronanez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devrchancay@alejandronanez@icarlossz