Skip to content

Translate: Typechecking With PropTypes - #113

Merged
alejandronanez merged 4 commits into
reactjs:masterfrom
jnosornov:typechecking-with-proptypes-translation
Feb 8, 2019
Merged

Translate: Typechecking With PropTypes#113
alejandronanez merged 4 commits into
reactjs:masterfrom
jnosornov:typechecking-with-proptypes-translation

Conversation

@jnosornov

@jnosornovjnosornov commented Feb 6, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to issue #4.

Have some doubts about some therminology translation.

  • typecheking
  • validator

Check out the PR and let me know.

@jnosornovjnosornov changed the title Typechecking with proptypes translationTranslate: Typechecking With PropTypesFeb 6, 2019
RamirezAlex
RamirezAlex reviewed Feb 7, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 7, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 7, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 7, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 7, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
@jnosornovjnosornov mentioned this pull request Feb 7, 2019
Closed
@RamirezAlex

RamirezAlex commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

Thank you @jnosornov! Great job! LGTM 👍

alejandronanez
alejandronanez suggested changes Feb 7, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnosornov 👋 great work so far!

There are 4 changes that need to be made before merging this!

Thanks for your effort!

Also, thanks @RamirezAlex for reviewing this work! 👍

Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
alejandronanez
alejandronanez approved these changes Feb 8, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @jnosornov, thanks for addressing all these changes! Also, welcome to the project!

Merging this now!!!!

@alejandronanez
alejandronanez merged commit 8ebf5de into reactjs:masterFeb 8, 2019
@jnosornov

jnosornov commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

thanks guys for the review @RamirezAlex and @alejandronanez. Now move on! 💯

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@RamirezAlexRamirezAlexRamirezAlex left review comments
@alejandronanezalejandronanezalejandronanez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnosornov@RamirezAlex@alejandronanez