Skip to content

Translate: React without ES6 - #118

Merged
carburo merged 17 commits into
reactjs:masterfrom
adielhercules:translate/react-without-es6
Feb 7, 2019
Merged

Translate: React without ES6#118
carburo merged 17 commits into
reactjs:masterfrom
adielhercules:translate/react-without-es6

Conversation

@adielhercules

@adielherculesadielhercules commented Feb 7, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Translate: React without ES6

Reference to #109

@adielherculesadielhercules changed the title [WIP] Translate: React without ES6Translate: React without ES6Feb 7, 2019
@adielherculesadielhercules mentioned this pull request Feb 7, 2019
Closed
carburo
carburo requested changes Feb 7, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adielhercules. Welcome!
I made some corrections and suggetions that I think should be addressed before merging.
Thank you for your contribution!

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
carburoand others added 10 commits February 7, 2019 11:53
@carburo@adielhercules
Update content/docs/react-without-es6.md
811f5d9
change plana -> simple (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
b06230f
change es definido -> se define (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
cb55d42
change pasado a createReactClass -> que se le pasa (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
7cdb78d
change linea -> línea (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
69de049
change event handler -> *event handler* (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
5d38da5
change funciones de flecha -> funciones flecha (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
8ed5d88
change correaran -> se ejecutan (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
24e9093
change tu aun -> aun (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
06dac6d
change tu debes -> debes (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
d27f565
change typos (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@adielhercules

adielhercules commented Feb 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@carburo perfect, I already pushed all the suggestions! Thanks

@adielhercules

adielhercules commented Feb 7, 2019

Copy link
Copy Markdown
ContributorAuthor

Oh it seems that I still have a few suggestions pending to be fixed, let me fix that.

carburoand others added 6 commits February 7, 2019 12:04
@carburo@adielhercules
Update content/docs/react-without-es6.md
6c736e6
change on sentence about properties binding (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
24c6b78
change parts on sentence about performance when using `.bind` explicitly (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
2d3f9a0
change on sentence about boilerplate alternative (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
548eaee
change to fix typo (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
dd6f69b
change to fix typo (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo@adielhercules
Update content/docs/react-without-es6.md
17a5715
change to fix typos on experimental warning (as suggested)
Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo

carburo commented Feb 7, 2019

Copy link
Copy Markdown
Member

Ok, I think we are good to go. Thanks again!

@carburo
carburo merged commit cbd4cae into reactjs:masterFeb 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adielhercules@carburo