Skip to content

Spanish translation of faq-functions - #124

Merged
carburo merged 7 commits into
reactjs:masterfrom
florenciasilva:faq-functions-translation
Feb 14, 2019
Merged

Spanish translation of faq-functions#124
carburo merged 7 commits into
reactjs:masterfrom
florenciasilva:faq-functions-translation

Conversation

@florenciasilva

@florenciasilvaflorenciasilva commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@florenciasilvaflorenciasilva mentioned this pull request Feb 8, 2019
Closed
@carburocarburo self-assigned this Feb 12, 2019
carburo
carburo requested changes Feb 12, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @florenciasilva Thank you for your contribution!
Please, take a look at the suggestions I made and feel free to reply when you don't agree.

Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
@carburocarburo changed the title Spanish translation of faq-functions to a 100%, pending feedbackSpanish translation of faq-functionsFeb 12, 2019
@carburo@florenciasilva
Apply suggestions from code review
6b923f2
Co-Authored-By: florenciasilva <hensgrej@gmail.com>
@alejandronanez

alejandronanez commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?

Thanks!

@carburo@florenciasilva
Apply suggestions from code review
d3baf99
Co-Authored-By: florenciasilva <hensgrej@gmail.com>
@florenciasilva

florenciasilva commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?

Thanks!

Hey! I just committed all the changes, so it should be ready for a review!

@carburo

carburo commented Feb 14, 2019

Copy link
Copy Markdown
Member

Thank you! I'm merging it then.

@carburo
carburo merged commit f729af3 into reactjs:masterFeb 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo requested changes

Assignees

@carburocarburo

Labels

has-reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florenciasilva@alejandronanez@carburo