Skip to content

Translate Higher Order Components - #125

Merged
carburo merged 7 commits into
reactjs:masterfrom
elyalvarado:higher-order-components
Feb 10, 2019
Merged

Translate Higher Order Components#125
carburo merged 7 commits into
reactjs:masterfrom
elyalvarado:higher-order-components

Conversation

@elyalvarado

@elyalvaradoelyalvarado commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@elyalvaradoelyalvarado mentioned this pull request Feb 8, 2019
Closed
@elyalvarado

elyalvarado commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

#4

icarlossz
icarlossz suggested changes Feb 8, 2019
View reviewed changes

@icarlosszicarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left you some comments! 👍

Comment threadcontent/docs/higher-order-components.md
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md
Comment threadcontent/docs/higher-order-components.md Outdated
@elyalvarado

elyalvarado commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @icarlossz for your reviews, I merged some and left comments on the others

@icarlossz

icarlossz commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

Thanks! I learned a lot in this PR 😅

@elyalvarado

elyalvarado commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Hey @RamirezAlex, @carburo will you take a look at this translation? I appreciate your comments from previous translations and I think this one will benefit from an extra pair of eyes.

RamirezAlex
RamirezAlex reviewed Feb 8, 2019
View reviewed changes

@RamirezAlexRamirezAlex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work in general, I only that small type and the missing comma :)

Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
@elyalvarado

elyalvarado commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@carburo@alejandronanez I think this is ready for merging

carburo
carburo reviewed Feb 10, 2019
View reviewed changes

@carburocarburo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I mostly fixed a few typos and added some missing inverted exclamation and question marks.
Merging...

@carburo
carburo merged commit fcf85a3 into reactjs:masterFeb 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo left review comments
+2 more reviewers
@RamirezAlexRamirezAlexRamirezAlex left review comments
@icarlosszicarlosszicarlossz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elyalvarado@icarlossz@RamirezAlex@carburo