Uh oh!
There was an error while loading. Please reload this page.
Translate: Strict mode - #126
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jonalvarezz
commented
Feb 9, 2019
Great job David 😁! I've added some comments. |
initdav
commented
Feb 11, 2019
Thanks Jonathan! I just made a commit applying those comments. |
alejandronanez
left a comment
There was a problem hiding this comment.
Hey @d4vsanchez, thanks for working on this, this PR is looking reaaally good, just left a couple of minor comments that I think we should address before merging.
If you think that my suggestions don't apply, just let me know, we can talk about it!
Thanks again for your contribution!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| * `shouldComponentUpdate` | ||
| * `render` | ||
| * `setState` updater functions (the first argument) | ||
| * Funciones de actualización de `setState` (el primer argumento) |
There was a problem hiding this comment.
I don't understand this one, is it OK? haha
There was a problem hiding this comment.
haha it sounds good I think 😂
initdav
commented
Feb 12, 2019
Hey @alejandronanez, they were very valuable! I have made a new commit applying those suggestions and also modifying the "Advertencia" in the bullet points section.. |
I've done translating
Strict modeto Spanish. #4I'm having some doubts with some stuff in the translation and I hope you can help me with them if you have a better way to translate it:
fase de confirmación.string ref,callback ref,object ref. I've basically left them as is; I can instead translate themreferencia de string(to comply with the translation guideline table),referencia de objetoandreferencia de callback. What do you think it's better?cc: @alejandronanez@dmoralesm@carburo