Skip to content

Translate: Strict mode - #126

Merged
alejandronanez merged 6 commits into
reactjs:masterfrom
initdav:master
Feb 12, 2019
Merged

Translate: Strict mode#126
alejandronanez merged 6 commits into
reactjs:masterfrom
initdav:master

Conversation

@initdav

Copy link
Copy Markdown
Contributor

I've done translating Strict mode to Spanish. #4

I'm having some doubts with some stuff in the translation and I hope you can help me with them if you have a better way to translate it:

  • commit phase: I'm translating this as fase de confirmación.
  • refs: This article talks about refs in multiple ways: string ref, callback ref, object ref. I've basically left them as is; I can instead translate them referencia de string (to comply with the translation guideline table), referencia de objeto and referencia de callback. What do you think it's better?

cc: @alejandronanez@dmoralesm@carburo

Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md
Comment threadcontent/docs/addons-test-utils.md Outdated
@jonalvarezz

Copy link
Copy Markdown

Great job David 😁! I've added some comments.

@initdav

Copy link
Copy Markdown
ContributorAuthor

Thanks Jonathan! I just made a commit applying those comments.

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @d4vsanchez, thanks for working on this, this PR is looking reaaally good, just left a couple of minor comments that I think we should address before merging.

If you think that my suggestions don't apply, just let me know, we can talk about it!

Thanks again for your contribution!

Comment threadcontent/docs/strict-mode.md Outdated
Comment threadcontent/docs/strict-mode.md Outdated
* `shouldComponentUpdate`
* `render`
* `setState` updater functions (the first argument)
* Funciones de actualización de `setState` (el primer argumento)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this one, is it OK? haha

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha it sounds good I think 😂

@initdav

Copy link
Copy Markdown
ContributorAuthor

Hey @alejandronanez, they were very valuable! I have made a new commit applying those suggestions and also modifying the "Advertencia" in the bullet points section..

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejandronanez
alejandronanez merged commit b2d481d into reactjs:masterFeb 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@initdav@jonalvarezz@alejandronanez@carburo