Skip to content

Jsx - #128

Merged
carburo merged 39 commits into
reactjs:masterfrom
jvelezpo:jsx
Feb 12, 2019
Merged

Jsx#128
carburo merged 39 commits into
reactjs:masterfrom
jvelezpo:jsx

Conversation

@jvelezpo

@jvelezpojvelezpo commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

Relates to: #4

carburo
carburo requested changes Feb 9, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go! Thank you for your contribution. I made several comments. Review them, commit the proposed changes if you agree and otherwise tell me why should we leave it as is.

Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
carburo
carburo reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
carburo
carburo reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
@carburocarburo self-assigned this Feb 12, 2019
@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
carburoand others added 22 commits February 12, 2019 08:09
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
6f05591
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
164f6f0
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
47ef299
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
2578498
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
7d55fcd
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
25a81a7
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
9f3f984
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
d0c84f6
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
4372802
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
4934d0a
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
1bfb706
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
3c122e5
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
dd23c36
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
e5ea563
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
58731ac
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
704666d
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
0e93035
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
57c72c1
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
9abf91c
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
1f6c4db
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
462ffd3
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
0fe65df
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
carburoand others added 14 commits February 12, 2019 08:16
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
7ca3eab
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
f71fcb5
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
fae15ab
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
1ae6f79
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
df6ce74
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
27f43a9
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
1ef283d
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
6feff0e
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
6893198
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
1d040ef
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
8ad3bbb
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
2527f24
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
e48fbae
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo@jvelezpo
Update content/docs/jsx-in-depth.md
00988f1
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@carburo

carburo commented Feb 12, 2019

Copy link
Copy Markdown
Member

Ok, thank you! Merging!

@carburo
carburo merged commit 4d9afb7 into reactjs:masterFeb 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo requested changes

Assignees

@carburocarburo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvelezpo@carburo