Skip to content

Translation Static-type-checking - #136

Merged
carburo merged 9 commits into
reactjs:masterfrom
Paolore:static-type-checking
Feb 10, 2019
Merged

Translation Static-type-checking#136
carburo merged 9 commits into
reactjs:masterfrom
Paolore:static-type-checking

Conversation

@Paolore

@PaolorePaolore commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

RamirezAlex
RamirezAlex reviewed Feb 10, 2019
View reviewed changes

@RamirezAlexRamirezAlex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Just a few suggestions ;-)

Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
@PaolorePaolore mentioned this pull request Feb 10, 2019
Closed
carburo
carburo requested changes Feb 10, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go! I fixed some typos and made some suggestions.

Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
Comment threadcontent/docs/static-type-checking.md Outdated
@Paolore

Paolore commented Feb 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @carburo, I made the changes you suggested, thanks.
and I'm sorry there were many, especially one that made me embarrass. jejeje

@carburo
carburo merged commit fb633df into reactjs:masterFeb 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo requested changes
+1 more reviewer
@RamirezAlexRamirezAlexRamirezAlex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Paolore@RamirezAlex@carburo