Skip to content

[Done] Translate: Design Principles - #146

Merged
carburo merged 8 commits into
reactjs:masterfrom
elyalvarado:design-principles
Feb 15, 2019
Merged

[Done] Translate: Design Principles#146
carburo merged 8 commits into
reactjs:masterfrom
elyalvarado:design-principles

Conversation

@elyalvarado

@elyalvaradoelyalvarado commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@elyalvaradoelyalvarado mentioned this pull request Feb 12, 2019
Closed
@elyalvarado

elyalvarado commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

#4

@elyalvaradoelyalvarado changed the title WIP Translate: Design Principles[Done] Translate: Design PrinciplesFeb 14, 2019
@carburo
carburo self-requested a review February 14, 2019 22:27
carburo
carburo requested changes Feb 15, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you! The review is ready. Most of it is reduced to a few typos. I also added heading ids, as described in the translation guide. Check it out.

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
carburoand others added 2 commits February 14, 2019 20:37
@carburo@elyalvarado
Apply suggestions from code review
41eabfd
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@elyalvarado
Change text according to suggestions
9b9eb8b
@elyalvarado

elyalvarado commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@carburo, thanks for your review. I applied all of the suggested changes, it was a really long and complex article and even though I read it 3 times it was hard for me to spot any errors.

@carburo
carburo merged commit cfedfbe into reactjs:masterFeb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo requested changes

Assignees

No one assigned

Labels

changes-requestedhas-reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elyalvarado@carburo@alejandronanez