Skip to content

Introducing Hooks Spanish translation - #156

Merged
Darking360 merged 7 commits into
reactjs:masterfrom
KevinGomezDev:hooks-intro
Feb 18, 2019
Merged

Introducing Hooks Spanish translation#156
Darking360 merged 7 commits into
reactjs:masterfrom
KevinGomezDev:hooks-intro

Conversation

@KevinGomezDev

@KevinGomezDevKevinGomezDev commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

Since there's not a current translation for Hooks FAQ, i used [Preguntas frecuentes acerca de Hooks] as a translation for Hooks FAQ

@KevinGomezDevKevinGomezDev mentioned this pull request Feb 16, 2019
Closed
@Darking360
Darking360 self-requested a review February 17, 2019 02:06
icarlossz
icarlossz suggested changes Feb 17, 2019
View reviewed changes

@icarlosszicarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments.

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Darking360
Darking360 reviewed Feb 17, 2019
View reviewed changes

@Darking360Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @KevinGomezDev and thanks for an amazing PR 🚀

I just left you some comments, must of them are just typos, accents and some word changes or order, also thanks for your items @icarlossz 💪 Read them, fix those and update the PR. Let me know for any questions.

Thanks once again 🥇

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
@KevinGomezDev

KevinGomezDev commented Feb 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Darking360@icarlossz Fixes were added on commits d48b938 and a21f526, let me know if there's something else missing or if it is ready to go.

@Darking360

Darking360 commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

@KevinGomezDev Everything looks good for me. I just added a uppercase n for React Native and translate back to english the code example since we're doing those in english unless they are comments, I already pushed those so 🚀 Thanks again for the amazing work 🍺

@Darking360
Darking360 merged commit 0884335 into reactjs:masterFeb 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Darking360Darking360Darking360 left review comments
@icarlosszicarlosszicarlossz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changes-requestedhas-reviewerneeds-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinGomezDev@Darking360@icarlossz@carburo