Skip to content

Translate LayoutFooter and LayoutHeader - #160

Merged
carburo merged 8 commits into
reactjs:masterfrom
Zitle-Nancy:translate/layoutFooter/layoutHeader
Feb 17, 2019
Merged

Translate LayoutFooter and LayoutHeader#160
carburo merged 8 commits into
reactjs:masterfrom
Zitle-Nancy:translate/layoutFooter/layoutHeader

Conversation

@Zitle-Nancy

@Zitle-NancyZitle-Nancy commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Zitle-NancyZitle-Nancy mentioned this pull request Feb 16, 2019
Closed
@carburo
carburo self-requested a review February 17, 2019 00:15
@carburocarburo mentioned this pull request Feb 17, 2019
Closed
10 tasks
icarlossz
icarlossz suggested changes Feb 17, 2019
View reviewed changes

@icarlosszicarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I left you some comments :)

Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/docs/nav.yml Outdated
Comment threadcontent/docs/nav.yml Outdated
Comment threadcontent/docs/nav.yml Outdated
carburo
carburo approved these changes Feb 17, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks again! I just made some (mostly cosmetic) changes directly as we are trying to have this part of the site translated ASAP.

@carburo
carburo merged commit fca4773 into reactjs:masterFeb 17, 2019
@Zitle-Nancy

Zitle-Nancy commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

You're welcome, It was a pleasure , if you need anything else just let me know.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
+1 more reviewer
@icarlosszicarlosszicarlossz requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has-reviewerneeds-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zitle-Nancy@carburo@icarlossz