Skip to content

Translated render-props - #182

Merged
Darking360 merged 15 commits into
reactjs:masterfrom
jonathanpalma:master
Feb 27, 2019
Merged

Translated render-props#182
Darking360 merged 15 commits into
reactjs:masterfrom
jonathanpalma:master

Conversation

@jonathanpalma

@jonathanpalmajonathanpalma commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@jonathanpalmajonathanpalma mentioned this pull request Feb 25, 2019
Closed
@netlify

netlifyBot commented Feb 25, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for es-reactjs ready!

Built with commit 5ba9be0

https://deploy-preview-182--es-reactjs.netlify.com

@Darking360
Darking360 self-requested a review February 25, 2019 14:37
Darking360
Darking360 reviewed Feb 25, 2019
View reviewed changes

@Darking360Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @jonathanpalma ! Thank you for a great job! 🚀

I left you some comments, it's really good in general, just take back to english some code parts that we're not translating, a little typo and some changes to give a clearer reading. Please let me know for any questions or when you have those 💪 Then we'd be good to go 🥇

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
<div style={{ height: '100%' }} onMouseMove={this.handleMouseMove}>
<h1>Move the mouse around!</h1>
<p>The current mouse position is ({this.state.x}, {this.state.y})</p>
<h1>¡Mueve el cursor alrededor!</h1>

@Darking360Darking360Feb 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>¡Mueve el cursor alrededor!</h1>
<h1>Move the mouse around!</h1>

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Darking360and others added 7 commits February 25, 2019 13:13
@Darking360@jonathanpalma
Update content/docs/render-props.md
d4c9a75
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@Darking360@jonathanpalma
Update content/docs/render-props.md
d153dd3
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@Darking360@jonathanpalma
Update content/docs/render-props.md
80e1838
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@Darking360@jonathanpalma
Update content/docs/render-props.md
1dd2511
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@Darking360@jonathanpalma
Update content/docs/render-props.md
68b731d
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@Darking360@jonathanpalma
Update content/docs/render-props.md
028e528
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@jonathanpalma
Removed translations of code blocks
97f5c9e
@jonathanpalma

jonathanpalma commented Feb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Hey @Darking360, thanks for your review, I already updated all the changes you recommended, could you please check again?

icarlossz
icarlossz suggested changes Feb 26, 2019
View reviewed changes

@icarlosszicarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I suggested a few changes and typos. Thanks.

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
alejandronanez
alejandronanez suggested changes Feb 26, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jonathanpalma!

Thanks for your contribution, I left some extra comments here that are worth addressing before merging!

This is looking great so far, thanks for all your hard work!

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Darking360
Darking360 approved these changes Feb 27, 2019
View reviewed changes

@Darking360Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @jonathanpalma 🌞

Thanks for addressing the changes from the guys, I saw some markdown issues and an accent left but I added those so no worries 💪 Thanks for the great work, you rock! 🚀

@Darking360
Darking360 merged commit 95c345f into reactjs:masterFeb 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@alejandronanezalejandronanezalejandronanez requested changes
@Darking360Darking360Darking360 approved these changes
@icarlosszicarlosszicarlossz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has-reviewerneeds-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanpalma@alejandronanez@Darking360@icarlossz