Skip to content

Translate SyntheticEvent - #29

Merged
alejandronanez merged 38 commits into
reactjs:masterfrom
Cavallando:translate-syntheticevent
Feb 2, 2019
Merged

Translate SyntheticEvent#29
alejandronanez merged 38 commits into
reactjs:masterfrom
Cavallando:translate-syntheticevent

Conversation

@Cavallando

@CavallandoCavallando commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Translation of SyntheticEvent section. Had a lot of help from my friend who speaks Spanish as his first language, please let me know anything that you think might need some help!

Referencing Issue: #26

@CavallandoCavallando mentioned this pull request Feb 1, 2019
Closed
@Cavallando

Cavallando commented Feb 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Github is not allowing me to assign, I believe due to permissions (unless I am missing something dumb). Want to make sure I am following the contributing guidelines, hopefully this comment is acceptable form of assigning! @dmoralesm, @carburo and @alejandronanez

@alejandronanez

alejandronanez commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Hey @michaelcavallaro03, thanls for this PR! Welcome 👏

You're not dumb (please don't say that), you just don't have enough permissions. I'll set that up for you, thanks again!

@alejandronanez
alejandronanez self-requested a review February 1, 2019 17:16
EzequielMonforte
EzequielMonforte reviewed Feb 1, 2019
View reviewed changes
Comment threadcontent/docs/reference-events.md Outdated
hugmanrique
hugmanrique suggested changes Feb 1, 2019
View reviewed changes

@hugmanriquehugmanrique left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some incorrect translations and typos, but this PR looks pretty good!

Thanks for your work 😊

Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
EzequielMonforteand others added 12 commits February 1, 2019 11:40
@EzequielMonforte@Cavallando
Update content/docs/reference-events.md
0dd1e42
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
70c5655
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
c371fb2
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
7967f3d
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
4a25ae8
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
d570bc0
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
be63fa2
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
3638bef
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
567ef70
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
8cb0dab
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
30da3dd
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
5ce83b7
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique

hugmanrique commented Feb 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed the event name suggestions, thanks gariasf 😜

hugmanriqueand others added 7 commits February 1, 2019 12:56
@hugmanrique@Cavallando
Update content/docs/reference-events.md
624a518
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
07395f2
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
0fcdd04
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
7f02948
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
f898da5
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
6395484
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
7afaa7c
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
hugmanriqueand others added 8 commits February 1, 2019 13:12
@hugmanrique@Cavallando
Update content/docs/reference-events.md
22dfc8c
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
372daa7
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
44799c5
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
2d6346c
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique@Cavallando
Update content/docs/reference-events.md
3ce6ad5
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Michael Cavallaro
Requested Changes
31d8b85
Michael Cavallaro
Merge branch 'translate-syntheticevent' ofhttps://github.com/michael…
7e510f7
…cavallaro03/es.reactjs.org into translate-syntheticevent
Michael Cavallaro
Fixed requested changes
65cd54c
@Cavallando

Cavallando commented Feb 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you all for your comments and your work reviewing/translating overall! I added the changes that you all discussed/requested. Please let me know if there is anything else necessary to change!

alejandronanez
alejandronanez suggested changes Feb 1, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @michaelcavallaro03,

Thanks for your PR, this is getting close to what we want!

I'm requesting changes because of this https://github.com/reactjs/es.reactjs.org/pull/29/files#diff-551c454828b77e72a3859b9731768e7eR250

Let us know if you need help with anything else!

Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
alejandronanezand others added 7 commits February 1, 2019 17:12
@alejandronanez@Cavallando
Update content/docs/reference-events.md
ce57fda
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@alejandronanez@Cavallando
Update content/docs/reference-events.md
ed777c6
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@alejandronanez@Cavallando
Update content/docs/reference-events.md
4635e9d
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@alejandronanez@Cavallando
Update content/docs/reference-events.md
ad2cd46
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@alejandronanez@Cavallando
Update content/docs/reference-events.md
a557b33
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@alejandronanez@Cavallando
Update content/docs/reference-events.md
36fcf51
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@Cavallando
Fixed requested changes
9323ca8
@Cavallando

Cavallando commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Committed your suggestions @alejandronanez as well as removed that silly usage of React as a verb and kept polyfill as is!

alejandronanez
alejandronanez approved these changes Feb 2, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @michaelcavallaro03, thanks for your contribution!

Merging!

@alejandronanez
alejandronanez merged commit 465759d into reactjs:masterFeb 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo left review comments
+4 more reviewers
@gariasfgariasfgariasf left review comments
@hugmanriquehugmanriquehugmanrique requested changes
@EzequielMonforteEzequielMonforteEzequielMonforte left review comments
@alejandronanezalejandronanezalejandronanez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Cavallando@alejandronanez@hugmanrique@carburo@gariasf@EzequielMonforte