Skip to content

Building your Own Hooks Translation - #34

Merged
carburo merged 2 commits into
reactjs:masterfrom
EzequielMonforte:custom-hooks
Feb 5, 2019
Merged

Building your Own Hooks Translation#34
carburo merged 2 commits into
reactjs:masterfrom
EzequielMonforte:custom-hooks

Conversation

@EzequielMonforte

@EzequielMonforteEzequielMonforte commented Feb 1, 2019•
edited by alejandronanez
Loading

Copy link
Copy Markdown
Contributor

Closes#31

carburo
carburo requested changes Feb 2, 2019
View reviewed changes
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
Comment threadcontent/docs/hooks-custom.md Outdated
@carburo

carburo commented Feb 2, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@EzequielMonforte Thanks! I made some suggestions that I think need to be addressed before merging.

gariasf
gariasf reviewed Feb 2, 2019
View reviewed changes
Comment threadcontent/docs/hooks-custom.md Outdated
gariasf
gariasf reviewed Feb 2, 2019
View reviewed changes
Comment threadcontent/docs/hooks-custom.md Outdated
@gariasf

gariasf commented Feb 2, 2019

Copy link
Copy Markdown

Hey, I also replied to some of @carburo's comments with new suggestions, so please check those out again.

@EzequielMonforte

EzequielMonforte commented Feb 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @gariasf and @carburo for your suggestions. I've been working with them

@carburocarburo reopened this Feb 5, 2019
@carburo
carburo merged commit 08c7793 into reactjs:masterFeb 5, 2019
@carburo

carburo commented Feb 5, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Ok, now is merged. Thank you!

@tesseralistesseralis mentioned this pull request Feb 5, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
+1 more reviewer
@gariasfgariasfgariasf left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EzequielMonforte@carburo@gariasf