Skip to content

Hello world translation - #5

Merged
alejandronanez merged 8 commits into
masterfrom
translate-hello-world
Feb 4, 2019
Merged

Hello world translation#5
alejandronanez merged 8 commits into
masterfrom
translate-hello-world

Conversation

@alejandronanez

@alejandronanezalejandronanez commented Jan 31, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #4

@tesseralistesseralis mentioned this pull request Jan 31, 2019
Closed
@alejandronanezalejandronanez mentioned this pull request Jan 31, 2019
Closed
dmoralesm
dmoralesm reviewed Jan 31, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
alejandronanez
alejandronanez commented Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
@alejandronanezalejandronanez changed the title WIP: Hello world translationHello world translationFeb 3, 2019
carburo
carburo reviewed Feb 3, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
carburoand others added 5 commits February 3, 2019 19:07
@carburo@alejandronanez
Update content/docs/hello-world.md
d5833e9
Co-Authored-By: alejandronanez <alejonanez@gmail.com>
@carburo@alejandronanez
Update content/docs/hello-world.md
2bfd4dd
Co-Authored-By: alejandronanez <alejonanez@gmail.com>
@carburo@alejandronanez
Update content/docs/hello-world.md
71d4570
Co-Authored-By: alejandronanez <alejonanez@gmail.com>
@carburo@alejandronanez
Update content/docs/hello-world.md
bce779c
That makes total sense.
Co-Authored-By: alejandronanez <alejonanez@gmail.com>
@carburo@alejandronanez
Update content/docs/hello-world.md
425f4ac
Co-Authored-By: alejandronanez <alejonanez@gmail.com>
@alejandronanez
alejandronanez merged commit 08a18a0 into masterFeb 4, 2019
@alejandronanez
alejandronanez deleted the translate-hello-world branch February 4, 2019 00:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo left review comments
+1 more reviewer
@dmoralesmdmoralesmdmoralesm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alejandronanez@carburo@dmoralesm