Skip to content

Translate DOM Elements - #59

Merged
carburo merged 7 commits into
reactjs:masterfrom
LuisRevillaM:translate-dom-elements
Feb 4, 2019
Merged

Translate DOM Elements#59
carburo merged 7 commits into
reactjs:masterfrom
LuisRevillaM:translate-dom-elements

Conversation

@LuisRevillaM

@LuisRevillaMLuisRevillaM commented Feb 2, 2019•
edited by carburo
Loading

Copy link
Copy Markdown
Contributor

Translating DOM Elements section of the API Reference to Spanish.
Relates to issue #25

@LuisRevillaMLuisRevillaM mentioned this pull request Feb 2, 2019
Closed
@LuisRevillaMLuisRevillaM changed the title WIP: Translate DOM Elements sectionTranslate DOM ElementsFeb 2, 2019
@LuisRevillaM

LuisRevillaM commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

I think I don't have permissions to assign you the PR, so I'm mentioning you here @dmoralesm , @carburo, @alejandronanez. Thank you!

carburo
carburo requested changes Feb 3, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LuisRevillaM for your contribution! I made some suggestions that I think should be addressed before merging.

Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
@carburo@LuisRevillaM
Apply suggestions from code review
7f96359
Co-Authored-By: LuisRevillaM <luisrevillameza@gmail.com>
@LuisRevillaM

LuisRevillaM commented Feb 3, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you @LuisRevillaM for your contribution! I made some suggestions that I think should be addressed before merging.

I just committed the changes. Thanks for the suggestions! The translation is much better now.

@carburo

carburo commented Feb 4, 2019

Copy link
Copy Markdown
Member

Looks great! Thanks.
Merging

@carburo
carburo merged commit 29820cb into reactjs:masterFeb 4, 2019
@tesseralistesseralis mentioned this pull request Feb 4, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LuisRevillaM@carburo