Skip to content

Translate hooks-state - #60

Merged
alejandronanez merged 5 commits into
reactjs:masterfrom
a13marquez:master
Feb 21, 2019
Merged

Translate hooks-state#60
alejandronanez merged 5 commits into
reactjs:masterfrom
a13marquez:master

Conversation

@a13marquez

@a13marqueza13marquez commented Feb 2, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @a13marquez, I see that some paragraphs are not being translated yet. I assume this PR is in WIP state still.

I updated the title of the PR to reflect this, once you're done, please, remove the WIP part of the title.

Ps. I didn't finish my review since this looks to be in progress.

}
```

We'll start learning about Hooks by comparing this code to an equivalent class example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this line?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


## Equivalent Class Example

If you used classes in React before, this code should look familiar:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what happened to this one?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

}
```

The state starts as `{ count: 0 }`, and we increment `state.count` when the user clicks a button by calling `this.setState()`. We'll use snippets from this class throughout the page.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to translate this

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alejandronanezalejandronanez changed the title Translate hooks-stateWIP: Translate hooks-stateFeb 3, 2019
@a13marquez

Copy link
Copy Markdown
ContributorAuthor

Yes, it is in progress, I forgot the WIP status, sorry. I will finish the translation and let you know

@a13marquez

Copy link
Copy Markdown
ContributorAuthor

And also I have a doubt about the comments inside the code. Should I translate them?

@carburo

Copy link
Copy Markdown
Member

@a13marquez Yes, it is ok to translate comments, but not anything else inside code blocks.

@a13marqueza13marquez changed the title WIP: Translate hooks-stateTranslate hooks-stateFeb 4, 2019

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @a13marquez, this is looking good, just left a minor comment that I think we should address before merging.

Also, it seems that we have merge conflicts, please, make sure to fix them too!

Thanks!!!

Comment threadcontent/docs/hooks-state.md Outdated
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for es-reactjs ready!

Built with commit db1a66b

https://deploy-preview-60--es-reactjs.netlify.com

@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for es-reactjs ready!

Built with commit 2f9a7df

https://deploy-preview-60--es-reactjs.netlify.com

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@a13marquez@carburo@alejandronanez