Uh oh!
There was an error while loading. Please reload this page.
Translation of State and Lifecycle - #62
Conversation
alejandronanez
left a comment
There was a problem hiding this comment.
Hey @carburo, this is looking good, you can merge it whenever you want.
Left a couple of questions though - they are not blocking this PR, but I think that are things that we should talk about down the road!
| ``` | ||
| To implement this, we need to add "state" to the `Clock` component. | ||
| Para implementar esto, necesitamos agregar «estado» al componente `Clock`. |
There was a problem hiding this comment.
No biggie, but I'm curious, why did you write «estado» instead of "estado"?
There was a problem hiding this comment.
Actually, "Spanish typography", the problem is that now I see this is not the norm everywhere. In Spain "Spanish" quotes are the norm but in some places like Mexico due to US influence (and also technology I guess), the most common are "English" quotes. In Cuba, for instance, Spanish quotes are used in books and media.
Any way can work I think. Once we arrive at a decision we should put in on the style guide and then make the appropriate changes in all the pages.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icarlossz
left a comment
There was a problem hiding this comment.
Great job! I left you some comments 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ``` | ||
| The merging is shallow, so `this.setState({comments})` leaves `this.state.posts` intact, but completely replaces `this.state.comments`. | ||
| La fusión es superficial, asi que `this.setState({comments})` deja intacto a `this.state.posts`, pero remplaza completamente `this.state.comments`. |
There was a problem hiding this comment.
Actually, both are correct. But I will change it to "reemplaza" because it seems to be the "canonical" form.
Closes#62