Skip to content

StrictMode translation to spanish - #656

Merged
carburo merged 8 commits into
reactjs:mainfrom
Dazzae-exe:translate-StrictMode
May 4, 2023
Merged

StrictMode translation to spanish#656
carburo merged 8 commits into
reactjs:mainfrom
Dazzae-exe:translate-StrictMode

Conversation

@Dazzae-exe

@Dazzae-exeDazzae-exe commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Strict Mode

  • Traducción a español de su doc.

Encantado de corregir algún cambio que se necesite asap.

@Dazzae-exe

Dazzae-exe commented Apr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@carburo Buen día carburo, espero puedas chequear el PR en cualquier momento. Saludos y un gran comienzo de semana 👍🏻.

@carburocarburo mentioned this pull request Apr 25, 2023
Closed
mateoguzmana
mateoguzmana reviewed Apr 27, 2023
View reviewed changes

@mateoguzmanamateoguzmana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente trabajo, se ve muy bien en general. Solo noté unas cosas pequeñas.

Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
@Dazzae-exe

Dazzae-exe commented Apr 28, 2023

Copy link
Copy Markdown
ContributorAuthor

@mateoguzmana Muchas gracias Mateo, ya hice push de los cambios que me pediste 👍🏻

soyjuanmacias
soyjuanmacias reviewed Apr 28, 2023
View reviewed changes
Comment threadsrc/content/reference/react/StrictMode.md Outdated
soyjuanmacias
soyjuanmacias reviewed Apr 28, 2023
View reviewed changes
Comment threadsrc/content/reference/react/StrictMode.md Outdated
carburo
carburo requested changes May 2, 2023
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Hola, @Dazzae-exe! ¡Muchas gracias por tu contribución! Te he dejado varios comentarios sobre algunos aspectos que deberías revisar antes de poder mezclar este PR.

Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
Comment threadsrc/content/reference/react/StrictMode.md Outdated
@github-actions

github-actionsBot commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mateoguzmana
mateoguzmana self-requested a review May 2, 2023 04:51
@Dazzae-exe
Dazzae-exe requested a review from carburoMay 4, 2023 14:32
@carburo
carburo merged commit 602f622 into reactjs:mainMay 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
@soyjuanmaciassoyjuanmaciasAwaiting requested review from soyjuanmacias
@mateoguzmanamateoguzmanaAwaiting requested review from mateoguzmana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dazzae-exe@carburo@soyjuanmacias@mateoguzmana