Skip to content

Using the Effect Hook - #66

Merged
carburo merged 24 commits into
reactjs:masterfrom
escorponox:hooks-effect
Feb 9, 2019
Merged

Using the Effect Hook#66
carburo merged 24 commits into
reactjs:masterfrom
escorponox:hooks-effect

Conversation

@escorponox

@escorponoxescorponox commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@alejandronanez

alejandronanez commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

👋 @escorponox welcome to this project.

Is this your PR still in progress? I see a lot of translated content but the title says [WIP], if it is ready for review, please update the title.

Thanks!

@tesseralistesseralis mentioned this pull request Feb 5, 2019
Closed
@escorponox

escorponox commented Feb 5, 2019

Copy link
Copy Markdown
ContributorAuthor

There is still a lot of content to be translated. I will remove the [WIP] once it is finished.

Thanks!!!

@escorponoxescorponox changed the title [WIP] Using the Effect HookUsing the Effect HookFeb 6, 2019
@escorponox

escorponox commented Feb 6, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ready for review. @alejandronanez@carburo@dmoralesm

@carburo
carburo self-requested a review February 7, 2019 16:24
carburo
carburo requested changes Feb 7, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a big one. Really good job!
I pointed out some small issues that should be addressed before merging.

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md
Comment threadcontent/docs/hooks-effect.md Outdated
carburoand others added 16 commits February 7, 2019 22:31
@carburo@escorponox
fix typo
b188f2c
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix quotes
1bdf031
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix missing word
0f7d70f
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
Fix markdown
21b2269
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
Missing word
a1438cb
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
Fix missing words
4fcd893
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix API article
06d8ea9
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix missing accents
f40301b
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix typo
e55a232
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix typo
8b6a4dc
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix typo
c58e3b4
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix typo
cc5135e
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix error
9cab72e
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo@escorponox
fix errors
db3cf5d
Co-Authored-By: escorponox <escorponox@gmail.com>
@escorponox
fix typo
a629835
Carlos Coves Prieto
fix missing content
3d5161f
@escorponox

escorponox commented Feb 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@carburo I think all issues are fixed.

alejandronanez
alejandronanez reviewed Feb 8, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md
Comment threadcontent/docs/hooks-effect.md Outdated
>Nota
>
>Eagle-eyed readers may notice that this example also needs a `componentDidUpdate` method to be fully correct. We'll ignore this for now but will come back to it in a [later section](#explanation-why-effects-run-on-each-update) of this page.
>Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página.

@alejandronanezalejandronanezFeb 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie, but I think that detallistas sounds a bit better than avispados.

What do you think?

Suggested change
>Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página.
>Los lectores detallistas podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página.

@escorponoxescorponoxFeb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perspicaces may fit better imho. Do you agree? detallista is used for personal relationships in Spain

https://dle.rae.es/?id=SkJr6XL

@carburo
carburo merged commit 4a7d069 into reactjs:masterFeb 9, 2019
@escorponox
escorponox deleted the hooks-effect branch February 11, 2019 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
+1 more reviewer
@alejandronanezalejandronanezalejandronanez left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@escorponox@alejandronanez@carburo