Skip to content

Adding translation to react-dom: APIs - #664

Merged
carburo merged 5 commits into
reactjs:mainfrom
s0alken:react-dom-apis-translation
May 3, 2023
Merged

Adding translation to react-dom: APIs#664
carburo merged 5 commits into
reactjs:mainfrom
s0alken:react-dom-apis-translation

Conversation

@s0alken

@s0alkens0alken commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

Traducción de react-dom: APIs. Atenderé cualquier revisión lo antes posible.

@carburocarburo mentioned this pull request Apr 28, 2023
Closed
@mateoguzmana
mateoguzmana self-requested a review May 2, 2023 04:52
carburo
carburo requested changes May 3, 2023
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s0alken ¡Muchas gracias por tu contribución! Está casi lista para que mezclarla, solo te dejé par de comentarios para que los revises. ¡Gracias!

Comment threadsrc/components/MDX/ExpandableCallout.tsx Outdated
const variantMap = {
deprecated: {
title: 'Deprecated',
title: 'Obsoleto',

@carburocarburoMay 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor, ¿podrías revertir este cambio?
La recomendación del equipo de React es no traducir elementos de la UI de momento para evitar conflictos en el futuro:

Keep in mind translating UI is best done closer to the end. We plan to make non-trivial code changes to the repo over the next few months. So it's best to focus on the content rather than on UI components.

Comment threadsrc/content/reference/react-dom/index.md Outdated
<Deprecated>

These APIs will be removed in a future major version of React.
Las siguientes APIs se eliminarán en las próximas versiones importantes de React.

@carburocarburoMay 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para mantener la consistencia en todas las páginas estamos utilizando la terminología mayor.menor.parche.

Suggested change
Las siguientes APIs se eliminarán en las próximas versiones importantes de React.
Las siguientes APIs se eliminarán en una próxima versión mayor de React.

@s0alken

s0alken commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Apliqué los cambios @carburo

@carburo
carburo enabled auto-merge (squash) May 3, 2023 19:19
carburo
carburo approved these changes May 3, 2023
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gracias!

@carburo
carburo merged commit 94c692d into reactjs:mainMay 3, 2023
@github-actions

github-actionsBot commented May 3, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
@mateoguzmanamateoguzmanaAwaiting requested review from mateoguzmana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s0alken@carburo@mateoguzmana