Skip to content

Translated Component from Legacy APIs - #668

Merged
mateoguzmana merged 3 commits into
reactjs:mainfrom
zeusvargas:TranslatingComponentLegacyApi
May 6, 2023
Merged

Translated Component from Legacy APIs#668
mateoguzmana merged 3 commits into
reactjs:mainfrom
zeusvargas:TranslatingComponentLegacyApi

Conversation

@zeusvargas

@zeusvargaszeusvargas commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

Added the translation of the Component md file, from the legacy APIs section.

The route is src\content\reference\react\Component.md

  1. I translated all the text information available that renders to the users and informs them about the Component section in the Legacy APIs. The titles are the same, but the explanations are now in spanish.
  2. Translated string messages in some parts of the code fragments, so the messages make more sense to spanish speakers. But I didn't change all the text words there because it's hard to doing it correctly without changing much of the original code fragments.

image

mateoguzmana
mateoguzmana reviewed Apr 30, 2023
View reviewed changes

@mateoguzmanamateoguzmana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la contribución! una página bien larga sin dudas.

Todo se ve muy bien en general, te dejé unos comentarios de cosas pequeñas que noté.

Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
Comment threadsrc/content/reference/react/Component.md Outdated
@zeusvargas@mateoguzmana
Update src/content/reference/react/Component.md
390d165
Co-authored-by: Mateo Guzmán <20783123+mateoguzmana@users.noreply.github.com>
@zeusvargas@mateoguzmana
Apply suggestions from code review
e5265ea
Added all the suggestions to the commit. The changes are for improving style and fixing typos.
Co-authored-by: Mateo Guzmán <20783123+mateoguzmana@users.noreply.github.com>
@zeusvargas

zeusvargas commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Gracias Mateo, se me habían pasado muchos errores. Ahí ya hice commit de tus sugerencias.

@mateoguzmana
mateoguzmana self-requested a review May 2, 2023 04:53
@github-actions

github-actionsBot commented May 3, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mateoguzmana
mateoguzmana merged commit 515068f into reactjs:mainMay 6, 2023
@carburocarburo mentioned this pull request May 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mateoguzmanamateoguzmanaAwaiting requested review from mateoguzmana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeusvargas@mateoguzmana