Skip to content

Translate: Create a New React App - #68

Merged
carburo merged 22 commits into
reactjs:masterfrom
elyalvarado:create-a-new-react-app
Feb 5, 2019
Merged

Translate: Create a New React App#68
carburo merged 22 commits into
reactjs:masterfrom
elyalvarado:create-a-new-react-app

Conversation

@elyalvarado

@elyalvaradoelyalvarado commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

Done with the translation for Create a New React App#63.

@elyalvaradoelyalvarado mentioned this pull request Feb 4, 2019
Closed
RamirezAlex
RamirezAlex reviewed Feb 4, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
EzequielMonforte
EzequielMonforte reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
@EzequielMonforte@elyalvarado
Update content/docs/create-a-new-react-app.md
80c1520
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
EzequielMonforte
EzequielMonforte reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md
EzequielMonforte
EzequielMonforte reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
EzequielMonforte
EzequielMonforte reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
EzequielMonforte
EzequielMonforte reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
carburo
carburo requested changes Feb 5, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @elyalvarado. Thank you for your contribution. I made some suggestions before merging.

Comment threadcontent/docs/create-a-new-react-app.md
Comment threadcontent/docs/create-a-new-react-app.md
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Para obtener la mejor experiencia de usuario y desarrollador use una cadena de herramientas integrada.

This page describes a few popular React toolchains which help with tasks like:
Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como:

@carburocarburoFeb 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como:
Esta página describe algunas populares cadenas de herramientas de React, las cuales ayudan con tareas como:

@elyalvaradoelyalvaradoFeb 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most common order for the adjective in Spanish is after the noun.

@carburocarburoFeb 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo sé, pero hice la sugerencia porque la frase modificada por «populares» (cadenas de herramientas de React) hace un poco ambigua la frase: ¿Son populares las herramientas o las cadenas?

@elyalvaradoelyalvaradoFeb 5, 2019•
edited by carburo
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case: "cadenas de herramientas de React" is the noun. Maybe the following wording is clearer:

  • Esta página describe algunas de las cadenas de herramientas de React más populares ...

@carburocarburoFeb 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would go with that.

Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
carburoand others added 13 commits February 5, 2019 14:14
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
7f465dd
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
522222a
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
5defadc
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
4eeeed4
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
bd35c40
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
58ce480
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
42e36c5
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
dbdc54f
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@elyalvarado
Update create-react-app.md
5ced4b5
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
d0742c1
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
c5cef11
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
8a0b61c
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@carburo@elyalvarado
Update content/docs/create-a-new-react-app.md
3af4ff6
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@elyalvarado

elyalvarado commented Feb 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@carburo I added some of the changes you requested, but in some others I respectfully disagree. Please check the comments and let me know.
There is also no info regarding wether I should squash the commit or not.

@elyalvarado

elyalvarado commented Feb 5, 2019 via email

Copy link
Copy Markdown
ContributorAuthor

@carburo

carburo commented Feb 5, 2019

Copy link
Copy Markdown
Member

Ok, I am going to squash and merge. Sorry, we do not have a proper style guide nor a contribution guide yet. We are working on it.

@carburo
carburo merged commit 3e28edb into reactjs:masterFeb 5, 2019
@carburocarburo mentioned this pull request Feb 5, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo requested changes
+2 more reviewers
@RamirezAlexRamirezAlexRamirezAlex left review comments
@EzequielMonforteEzequielMonforteEzequielMonforte left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elyalvarado@carburo@RamirezAlex@EzequielMonforte