Skip to content

Translate Warnings (Special props && unknown-prop ) - #69

Merged
carburo merged 5 commits into
reactjs:masterfrom
jvelezpo:Warnings
Feb 10, 2019
Merged

Translate Warnings (Special props && unknown-prop )#69
carburo merged 5 commits into
reactjs:masterfrom
jvelezpo:Warnings

Conversation

@jvelezpo

Copy link
Copy Markdown
Contributor

Relates to #36

  • Special props doc translated
  • unknown-prop translated

@jvelezpojvelezpo changed the title WarningsTranslate Warnings (Special props && unknown-prop )Feb 4, 2019

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvelezpo, thanks again for another contribution to the repo 🎉!

Could you please change the wording, from usted to please.

This is getting cloooose!

Comment threadcontent/warnings/special-props.md Outdated
Comment threadcontent/warnings/unknown-prop.md Outdated
alejandronanezand others added 2 commits February 6, 2019 18:58
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@jvelezpo

Copy link
Copy Markdown
ContributorAuthor

@alejandronanez made the changes 👍

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvelezpo, I left a comment that is worth addressing before merging,

Thanks!

Comment threadcontent/warnings/unknown-prop.md Outdated
@carburo
carburo merged commit 6185a04 into reactjs:masterFeb 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jvelezpo@alejandronanez@carburo