Skip to content

Translation of "Hooks at a Glance" page - #70

Merged
carburo merged 6 commits into
reactjs:masterfrom
GiuMagnani:patch-2
Feb 8, 2019
Merged

Translation of "Hooks at a Glance" page#70
carburo merged 6 commits into
reactjs:masterfrom
GiuMagnani:patch-2

Conversation

@GiuMagnani

@GiuMagnaniGiuMagnani commented Feb 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@GiuMagnaniGiuMagnani mentioned this pull request Feb 4, 2019
Closed
alejandronanez
alejandronanez suggested changes Feb 4, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GiuMagnani, thanks for your hard work here, this is getting super close to what we need! 🙌

I left a couple of suggestions that should be addressed before merging this!

Thanks a lot!

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
alejandronanezand others added 2 commits February 4, 2019 22:44
@alejandronanez@GiuMagnani
Update content/docs/hooks-overview.md
b4c5106
Fix missed "Hooks"
Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
@alejandronanez@GiuMagnani
Update content/docs/hooks-overview.md
69459a6
Fixed wrong translation for "Effect Hook".
Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
@GiuMagnani

GiuMagnani commented Feb 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @alejandronanez for the corrections! I already committed them. Let me know if there is anything else.

alejandronanez
alejandronanez approved these changes Feb 8, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always @GiuMagnani!

Thank you very much!

alejandronanez
alejandronanez suggested changes Feb 8, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiuMagnani, oops, it seems that you have some merge conflicts on your branch.

Please, fix them and this will be ready to merge!

@GiuMagnani

GiuMagnani commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

@alejandronanez I'll take a look, thanks!

@carburo
carburo merged commit b726491 into reactjs:masterFeb 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alejandronanezalejandronanezalejandronanez requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiuMagnani@alejandronanez@carburo