Skip to content

Accessibility translation - #74

Merged
alejandronanez merged 8 commits into
reactjs:masterfrom
ElRodrigote:accessibility-translation
Feb 23, 2019
Merged

Accessibility translation#74
alejandronanez merged 8 commits into
reactjs:masterfrom
ElRodrigote:accessibility-translation

Conversation

@ElRodrigote

@ElRodrigoteElRodrigote commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
@alejandronanez

alejandronanez commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Hey @ElRodrigote, what's the state of this PR? Are you still working on it?

Thanks!

@ElRodrigote

ElRodrigote commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@alejandronanez Hi!

Yes, I had a few personal issues this week but I'm working on it, I'll update now what I have so far. Sorry for the delay and not giving you guys an update status.

@alejandronanez

alejandronanez commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

all good @ElRodrigote no problem! thanks for letting us know!

@ElRodrigote

ElRodrigote commented Feb 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @alejandronanez !

Finally I've finished translating and proof reading the file, it was quite extensive haha, sorry for the delay, If you could please take a look and review it, it would be awesome.

I have a quick question, regarding titles having some kind of reference between braces. I've deleted them in the file, but would like to know if I should:
· Keep them as they are
· Translate them in situ
· Erase them

Cheers!

@alejandronanez
alejandronanez self-requested a review February 21, 2019 00:45
@alejandronanezalejandronanez changed the title WIP: Accessibility translationAccessibility translationFeb 21, 2019
alejandronanez
alejandronanez suggested changes Feb 21, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ElRodrigote, thanks for this!

Generally speaking, I see 3 things that we need to change.

  1. Bring back the # next to the titles
  2. Please, avoid the usage of usted in any form, we're writing everything with tú
  3. Remove the extra spaces in line # 9, all the text is bold now :D

Thank you,

Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
@ElRodrigote

ElRodrigote commented Feb 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @alejandronanez !

Thanks for the corrections and the review. I've noticed a few orthographic errors too so I fixed them. Please, let me know if any further changes are needed.

Cheers!
Rodrigo Ali.

@netlify

netlifyBot commented Feb 21, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for es-reactjs ready!

Built with commit feb73b6

https://deploy-preview-74--es-reactjs.netlify.com

alejandronanez
alejandronanez approved these changes Feb 23, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ElRodrigote, thanks for your hard work!

@ElRodrigote

ElRodrigote commented Feb 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you guys!

@alejandronanez
alejandronanez merged commit 2561d0e into reactjs:masterFeb 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alejandronanezalejandronanezalejandronanez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ElRodrigote@alejandronanez