Skip to content

Translate "separating events from effects" - #748

Merged
mateoguzmana merged 8 commits into
reactjs:mainfrom
danmondra:Translate-"Separating-events-from-effects"
Jun 20, 2023

Hidden character warning

The head ref may contain hidden characters: "Translate-"Separating-events-from-effects""
Merged

Translate "separating events from effects"#748
mateoguzmana merged 8 commits into
reactjs:mainfrom
danmondra:Translate-"Separating-events-from-effects"

Conversation

@danmondra

@danmondradanmondra commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Ya corregí los errores mencionados y otros encontrados. Revisé el build y si compila localmente sin problemas.

carburo
carburo reviewed Jun 20, 2023
View reviewed changes
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
@danmondra@carburo
Fix build by prop error
d9a95a6
Co-authored-by: Rainer Martinez <rmartinezfraga@yandex.com>
@danmondra

danmondra commented Jun 20, 2023

Copy link
Copy Markdown
ContributorAuthor

Listo, gracias por la corrección @carburo.

@github-actions

github-actionsBot commented Jun 20, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mateoguzmana
mateoguzmana approved these changes Jun 20, 2023
View reviewed changes

@mateoguzmanamateoguzmana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve todo muy bien @danmondra. ¡Gracias!

Siéntete libre de seguir contribuyendo.

Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
Comment threadsrc/content/learn/separating-events-from-effects.md Outdated
@mateoguzmana
mateoguzmana merged commit 0fcb384 into reactjs:mainJun 20, 2023
@mateoguzmanamateoguzmana mentioned this pull request Jun 20, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo left review comments
@mateoguzmanamateoguzmanamateoguzmana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmondra@carburo@mateoguzmana