Skip to content

Translate: Environment Requirements - #87

Merged
alejandronanez merged 5 commits into
reactjs:masterfrom
angelitaooo:environment-requirements
Feb 11, 2019
Merged

Translate: Environment Requirements#87
alejandronanez merged 5 commits into
reactjs:masterfrom
angelitaooo:environment-requirements

Conversation

@angelitaooo

@angelitaoooangelitaooo commented Feb 6, 2019

Copy link
Copy Markdown
Contributor
Relates to #4

@alejandronanezalejandronanez changed the title translateTranslate: Environment RequirementsFeb 6, 2019
alejandronanez
alejandronanez suggested changes Feb 6, 2019
View reviewed changes

@alejandronanezalejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @angelitaooo,

Congratulations for sending your first PR - this is looking good so far, I left a couple of minor changes that you should address in order to approve this PR.

Let us know when it's ready!

Thanks!

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
@tesseralistesseralis mentioned this pull request Feb 7, 2019
Closed
@tesseralis

tesseralis commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@alejandronanez the changes were easy enough I went ahead and did them myself. 🙂Will you take a look?

@carburo

carburo commented Feb 10, 2019

Copy link
Copy Markdown
Member

@alejandronanez Seems fine for me, it is a small page. I just fixed a typo (collección -> colección) and the inconsistent use of 'environment' (once as 'ambiente', once as 'entorno'). There is another small issue with the use of 'soportar' for tranlationg 'support', but I think we can leave that to the style guide. For me, it's ready to be merged.

@alejandronanez

alejandronanez commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

Say no more @carburo!

Merging!

@alejandronanez
alejandronanez merged commit 398aa5e into reactjs:masterFeb 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alejandronanezalejandronanezalejandronanez requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@angelitaooo@tesseralis@carburo@alejandronanez