Skip to content

Web Component translation - #88

Merged
carburo merged 5 commits into
reactjs:masterfrom
Paolore:master
Feb 6, 2019
Merged

Web Component translation#88
carburo merged 5 commits into
reactjs:masterfrom
Paolore:master

Conversation

@Paolore

@PaolorePaolore commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@PaolorePaolore mentioned this pull request Feb 6, 2019
Closed
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
carburo
carburo requested changes Feb 6, 2019
View reviewed changes

@carburocarburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Paolore! Nice job. Also thanks @RamirezAlex for the review.
I pointed out only the elements that must be fixed (typos). Review also the suggestions made by Alex and then we will probably be ready to merge.

Comment threadcontent/docs/web-components.md Outdated
Comment threadcontent/docs/web-components.md Outdated
Comment threadcontent/docs/web-components.md Outdated
Comment threadcontent/docs/web-components.md Outdated
Comment threadcontent/docs/web-components.md Outdated
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
RamirezAlex
RamirezAlex reviewed Feb 6, 2019
View reviewed changes
Comment threadcontent/docs/web-components.md Outdated
@RamirezAlex

RamirezAlex commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

Nice job @Paolore LGTM 👍

@carburo

carburo commented Feb 6, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Hi @Paolore, I was writing about the rationale behind not translating WebComponent and then you updated it. Great work with this PR!

@carburo
carburo merged commit a8a30c1 into reactjs:masterFeb 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburocarburocarburo approved these changes
+1 more reviewer
@RamirezAlexRamirezAlexRamirezAlex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Paolore@RamirezAlex@carburo