Skip to content

Translate Introducing Hooks - #18

Merged
itayyehezkel merged 6 commits into
reactjs:masterfrom
itayyehezkel:introducing-hooks
Mar 1, 2019
Merged

Translate Introducing Hooks#18
itayyehezkel merged 6 commits into
reactjs:masterfrom
itayyehezkel:introducing-hooks

Conversation

@itayyehezkel

@itayyehezkelitayyehezkel commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 26, 2019
Closed
88 tasks
galtalmor
galtalmor requested changes Feb 27, 2019
View reviewed changes

@galtalmorgaltalmor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments and fix line change issues in order for reviewers to be able to keep reviewing after line 45 (see the last comment). Thanks!

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md
Comment threadcontent/docs/hooks-intro.md Outdated
galtalmor
galtalmor requested changes Feb 28, 2019
View reviewed changes

@galtalmorgaltalmor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be so nitpicky, but there were some critical readability issues that I had to point out and then it started to stack up. Sorry if I'm being annoying and thanks for the contribution!

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
@itayyehezkel
itayyehezkel merged commit dbb63b9 into reactjs:masterMar 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galtalmorgaltalmorgaltalmor requested changes
+1 more reviewer
@mulimulimuli left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itayyehezkel@galtalmor@muli