Skip to content

Translate Code Editor Component - #27

Merged
itayyehezkel merged 2 commits into
reactjs:masterfrom
itayyehezkel:code-editor
Feb 27, 2019
Merged

Translate Code Editor Component#27
itayyehezkel merged 2 commits into
reactjs:masterfrom
itayyehezkel:code-editor

Conversation

@itayyehezkel

@itayyehezkelitayyehezkel commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 27, 2019
Closed
88 tasks
galnir
galnir previously requested changes Feb 27, 2019
View reviewed changes

@galnirgalnir left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to ask you to change להגרם to להיגרם but the word can be written in both ways, and we need to decide in what way we write it in our future TRANSLATION.md

@galnir
galnir dismissed their stale reviewFebruary 27, 2019 15:17

Doesn't need to be changed for now

@itayyehezkel

itayyehezkel commented Feb 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Yes you right, but I changed it anyway because it feels correct.

@itayyehezkel
itayyehezkel merged commit 3be560a into reactjs:masterFeb 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@galnirgalnirgalnir left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itayyehezkel@galnir