Skip to content

Home translation - #4

Merged
galnir merged 16 commits into
reactjs:masterfrom
gmadar:master
Feb 19, 2019
Merged

Home translation#4
galnir merged 16 commits into
reactjs:masterfrom
gmadar:master

Conversation

@gmadar

@gmadargmadar commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

I've chosen readability over correctness. So a few words are not translated (like state) and a few are just visually translated (like component which translated to קומפוננטה and not רכיב)

@gmadar
Update learn-once-write-anywhere.md
057c509
@gmadar
Update declarative.md
dfd7b72
@gmadar
Update component-based.md
5a6f943
@gmadar
Update declarative.md
828b87f
@gmadar
Update a-component-using-external-plugins.md
d6b575e
@gmadar
Update a-simple-component.md
8291b5a
השתמשתי בעברית לא תקנית כמו "קומפילציה" במקום "הידור" כדי שהטקסט יהיה יותר קריא ונגיש
@gmadar
Update a-simple-component.md
cee6a73
@gmadar
Update a-stateful-component.md
d622777
@gmadar
Update an-application.md
54877ea
@gmadar
Update a-simple-component.js
2b9a5f5
@gmadar
Update a-component-using-external-plugins.js
88b039f
@gmadar
Update a-component-using-external-plugins.js
86feb83
I assume that when finished the layout style will change to `direction:rtl, text-align:right`. When it will the example text with hebrew will look as expected
@gmadar
Update a-stateful-component.md
db19a44
galnir
galnir suggested changes Feb 14, 2019
View reviewed changes

@galnirgalnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments before we merge, and I also see some sentences in which words in Hebrew and words in English are not in the correct order( e.g component-based.md and a-simple-component.md)

Comment threadcontent/home/examples/a-component-using-external-plugins.md Outdated
Comment threadcontent/home/marketing/declarative.md Outdated
Comment threadcontent/home/examples/a-simple-component.md Outdated
@galnir

galnir commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

It looks good, just need to solve the punctuation problem before we merge. I'm looking for solutions atm

@bentlusty

bentlusty commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

What do you think about using React in English instead of translating it?

From the PR:
React components implement..
To: קומפוננטות React מיושמות...

@galnir

galnir commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

What do you think about using React in English instead of translating it?

From the PR:
React components implement..
To: קומפוננטות React מיושמות...

I've looked into other languages repos and they all seem to write 'React' in English

@gmadar

gmadar commented Feb 16, 2019

Copy link
Copy Markdown
ContributorAuthor

What do you think about using React in English instead of translating it?

From the PR:
React components implement..
To: קומפוננטות React מיושמות...

Where did I translated it?

@galnir
galnir merged commit ce87d9f into reactjs:masterFeb 19, 2019
@galtalmorgaltalmor mentioned this pull request Feb 25, 2019
Closed
88 tasks
gaearon pushed a commit that referenced this pull request Aug 5, 2021
@trueadm
Merge pull request#4from alexkrolick/create-ref-patch4
3f304b9
Misc fixes
gaearon pushed a commit that referenced this pull request Aug 5, 2021
@bvaughn
Merge pull request#4from alexkrolick/context-tweaks
3af89c9
Context tweaks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@galnirgalnirgalnir approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmadar@galnir@bentlusty