Skip to content

Update composition-vs-inheritance.md - #40

Merged
galtalmor merged 4 commits into
reactjs:masterfrom
dormd:master
Mar 11, 2019
Merged

Update composition-vs-inheritance.md#40
galtalmor merged 4 commits into
reactjs:masterfrom
dormd:master

Conversation

@dormd

@dormddormd commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

galtalmor
galtalmor requested changes Mar 4, 2019
View reviewed changes

@galtalmorgaltalmor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good, just a few small suggestions.
Also, in general for readability I would suggest always adding a dash (-) between ל, מ, כ, ב, so on and a word in English.
And lastly, I would try to keep standard quotes and not the special ״ ones

Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@tesseralistesseralis mentioned this pull request Mar 4, 2019
Closed
88 tasks
@dormd

dormd commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@galtalmor 👍

@galtalmor
galtalmor merged commit 8298bf3 into reactjs:masterMar 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galtalmorgaltalmorgaltalmor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dormd@galtalmor