Skip to content

translate TestUtilities - #52

Merged
galtalmor merged 3 commits into
reactjs:masterfrom
galnir:test-utilities
May 1, 2019
Merged

translate TestUtilities#52
galtalmor merged 3 commits into
reactjs:masterfrom
galnir:test-utilities

Conversation

@galnir

@galnirgalnir commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Apr 23, 2019
Closed
88 tasks
@netlify

netlifyBot commented Apr 23, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for he-reactjs ready!

Built with commit a311e78

https://deploy-preview-52--he-reactjs.netlify.com

galtalmor
galtalmor requested changes Apr 30, 2019
View reviewed changes

@galtalmorgaltalmor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.
They are in a "Suggested change" format so you can just approve them (or batch it) for your convenience.
Thanks!

Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
galtalmorand others added 2 commits April 30, 2019 19:38
@galtalmor@galnir
Apply suggestions from code review
7ff1a31
Co-Authored-By: galnir <36937694+galnir@users.noreply.github.com>
@galtalmor
Update addons-test-utils.md
a311e78
@galtalmor
galtalmor merged commit 333c8c5 into reactjs:masterMay 1, 2019
@galnir
galnir deleted the test-utilities branch December 7, 2021 09:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galtalmorgaltalmorgaltalmor approved these changes
@itayyehezkelitayyehezkelAwaiting requested review from itayyehezkel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@galnir@galtalmor