Skip to content

translate create a new react app - #55

Merged
galnir merged 3 commits into
reactjs:masterfrom
galnir:create-a-new-react-app
May 13, 2019
Merged

translate create a new react app#55
galnir merged 3 commits into
reactjs:masterfrom
galnir:create-a-new-react-app

Conversation

@galnir

@galnirgalnir commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Apr 24, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for he-reactjs ready!

Built with commit e298f0e

https://deploy-preview-55--he-reactjs.netlify.com

@tesseralistesseralis mentioned this pull request Apr 25, 2019
Closed
88 tasks
@itayyehezkel

itayyehezkel commented May 3, 2019

Copy link
Copy Markdown
Contributor

Looks Good, and seems that Netlify deployed another version.

galtalmor
galtalmor reviewed May 13, 2019
View reviewed changes
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
galtalmor
galtalmor reviewed May 13, 2019
View reviewed changes

@galtalmorgaltalmor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements and suggestions.
Thanks for the work!

Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
Comment threadcontent/docs/create-a-new-react-app.md Outdated
@galnir@galtalmor
Apply suggestions from code review
e298f0e
Co-Authored-By: Gal Talmor <galtalmor@users.noreply.github.com>
@galnir

galnir commented May 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @galtalmor 👍

@galnir
galnir merged commit f1414ff into reactjs:masterMay 13, 2019
@galnir
galnir deleted the create-a-new-react-app branch December 7, 2021 09:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galtalmorgaltalmorgaltalmor left review comments
@itayyehezkelitayyehezkelAwaiting requested review from itayyehezkel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@galnir@itayyehezkel@galtalmor