Skip to content

Translating reference-react-component.md - #65

Merged
galnir merged 15 commits into
reactjs:masterfrom
itzikya:master
May 18, 2019
Merged

Translating reference-react-component.md#65
galnir merged 15 commits into
reactjs:masterfrom
itzikya:master

Conversation

@itzikya

@itzikyaitzikya commented May 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented May 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for he-reactjs ready!

Built with commit c293164

https://deploy-preview-65--he-reactjs.netlify.com

galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir reviewed May 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-component.md Outdated
galnir
galnir suggested changes May 14, 2019
View reviewed changes

@galnirgalnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, It looks like you’ve put a lot of time into this. Check out my suggestions, some need to be applied(links and 'reference'), and some are only suggestions.

@tesseralistesseralis mentioned this pull request May 14, 2019
Closed
88 tasks
itzikyaand others added 10 commits May 15, 2019 17:11
@itzikya@galnir
Update content/docs/reference-react-component.md
11c528a
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
1395cfc
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
24b79ed
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
18f140a
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
070e288
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
1e1278e
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
b82501a
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
1a24bcb
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
c1ef0d5
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
2174603
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
itzikyaand others added 3 commits May 15, 2019 17:16
@itzikya@galnir
Update content/docs/reference-react-component.md
e6266a2
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
03d5973
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@itzikya@galnir
Update content/docs/reference-react-component.md
d1450b9
apply code review suggestions
Co-Authored-By: Nir <36937694+galnir@users.noreply.github.com>
@galnir

galnir commented May 15, 2019

Copy link
Copy Markdown
Contributor

@itzikya Btw I also didn't know this, next time you can go to the 'Files Changed' tab and 'add suggestion to batch' and commit them all once instead of committing each one.

@itzikya

itzikya commented May 17, 2019

Copy link
Copy Markdown
ContributorAuthor

@itzikya Btw I also didn't know this, next time you can go to the 'Files Changed' tab and 'add suggestion to batch' and commit them all once instead of committing each one.

I was searching for a way to do it, thanks!

@galnir
galnir merged commit f92f36f into reactjs:masterMay 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@galnirgalnirgalnir approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itzikya@galnir