Skip to content

Beta react developer tools translation done - #174

Merged
arshadkazmi42 merged 6 commits into
reactjs:mainfrom
Anishpras:beta-react-developer-tools
Jan 9, 2022
Merged

Beta react developer tools translation done#174
arshadkazmi42 merged 6 commits into
reactjs:mainfrom
Anishpras:beta-react-developer-tools

Conversation

@Anishpras

@AnishprasAnishpras commented Jan 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Anishpras

Anishpras commented Jan 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@arshadkazmi42 I have translated the page. Can you please review it?

@arshadkazmi42arshadkazmi42 added the 1st Review First phase of review label Jan 9, 2022
@arshadkazmi42
arshadkazmi42 self-requested a review January 9, 2022 11:52
arshadkazmi42
arshadkazmi42 requested changes Jan 9, 2022
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Added review once these are fixed its good to be merged.

Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
Comment threadbeta/src/pages/learn/react-developer-tools.md Outdated
@arshadkazmi42arshadkazmi42 mentioned this pull request Jan 9, 2022
Open
@Anishpras

Anishpras commented Jan 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@arshadkazmi42 I have done the changes. Thank you.

arshadkazmi42
arshadkazmi42 approved these changes Jan 9, 2022
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

Lets get this merged.

@arshadkazmi42
arshadkazmi42 merged commit 751c628 into reactjs:mainJan 9, 2022
@Anishpras
Anishpras deleted the beta-react-developer-tools branch January 9, 2022 15:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st ReviewFirst phase of reviewbeta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anishpras@arshadkazmi42