Uh oh!
There was an error while loading. Please reload this page.
Translated your first component - #204
Conversation
Akshit1025
commented
May 3, 2022
@arshadkazmi42 please review this pull request Thank You |
arshadkazmi42
commented
May 3, 2022
@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay |
Akshit1025
commented
May 3, 2022
ok no problem |
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on this.
I have added few comments till line 55
Lets' get these fixed and then I will continue with further review.
You can check for our review guidelines at #23
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Akshit1025
commented
May 12, 2022
@arshadkazmi42 Hey, I have changed all the typos that you have suggested till now. You can start reviewing further Thanks |
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on the fixes.
I have added more review comments till line 170.
Let's get these fixed, post that we can continue further with the review
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Akshit1025
commented
Dec 4, 2022
@arshadkazmi42 I have fixed the typos and now you can further review the translation |
arshadkazmi42
commented
Dec 4, 2022
@Akshit1025 There are two review comments which still have minor issues. Rest looks fine. I have marked them as unresolved, can you check and update those? Post that we can continue further. |
arshadkazmi42
commented
Dec 4, 2022
@Akshit1025 There is still one typo in the code block. Please check the unresolved comment |
Akshit1025
commented
Dec 6, 2022
@arshadkazmi42 typos have been fixed. Please carry on |
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
Akshit1025
commented
Dec 8, 2022
@arshadkazmi42 all the typos that you have suggested have been completed |
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work. Thank you for working on all the fixes.
lets get this merged 🎉
I have translated the Your First Component page. Please review it
Sections on the page
Please let me know if there are any changes that have to be made
Please checkmark these boxes too
Thank You