Uh oh!
There was an error while loading. Please reload this page.
Translation for "State: A Component's Memory". Solves issue #208 - #209
Conversation
yogesharma12
left a comment
There was a problem hiding this comment.
hi @MayurSMahajan
please use "कौम्पोनॅन्ट" instead of "घटक" on lines 156, 890, 892, 899 , 1500.
Other than that It's a solid translation 😃
MayurSMahajan
commented
Sep 3, 2022
alright |
MayurSMahajan
commented
Sep 3, 2022
I have replaced घटक with कौम्पोनॅन्ट and I have committed the changes in my forked repo, now do i need to open a new PR or does the exisiting pr will have my new commit? |
arshadkazmi42
commented
Sep 8, 2022
Your existing PR will have the new commits if you have done it on the same branch in your forked repo |
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on this.
I have added review till line 19.
Lets get these fixed, post these fixes we can continue on further review.
To know more about review process you can refer this ticket #23
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Original : Components often need to change what's on the screen as a result of an interaction. My Change : किसी क्रिया के परिणामस्वरूप कौम्पोनॅन्ट को अक्सर स्क्रीन पर जो कुछ भी है उसे बदलने की आवश्यकता होती है। Requested : कोई भी इंटरेक्शन होने की वजह स कौम्पोनॅन्ट को अक्सर स्क्रीन पर क्या दिख रहा है उसको बदलना होता है।
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you again for working on the fixes.
I have added more review till line 910.
Let's get these fixed and then we can continue further.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for working on the fixes.
I have added review comments for rest of the file.
Once these are fixed, we can get this merged
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for your patience and working on all the fixes during the review process.
This is ready to be merged now.
Lets get this merged 🎉
Solves the issue #208