Skip to content

Translation for "State: A Component's Memory". Solves issue #208 - #209

Merged
arshadkazmi42 merged 52 commits into
reactjs:mainfrom
MayurSMahajan:main
Feb 21, 2023
Merged

Translation for "State: A Component's Memory". Solves issue #208#209
arshadkazmi42 merged 52 commits into
reactjs:mainfrom
MayurSMahajan:main

Conversation

@MayurSMahajan

Copy link
Copy Markdown
Contributor

Solves the issue #208

@yogesharma12yogesharma12 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @MayurSMahajan
please use "कौम्पोनॅन्ट" instead of "घटक" on lines 156, 890, 892, 899 , 1500.
Other than that It's a solid translation 😃

@MayurSMahajan

Copy link
Copy Markdown
ContributorAuthor

hi @MayurSMahajan please use "कौम्पोनॅन्ट" instead of "घटक" on lines 156, 890, 892, 899 , 1500. Other than that It's a solid translation 😃

alright

@MayurSMahajan

Copy link
Copy Markdown
ContributorAuthor

hi @MayurSMahajan please use "कौम्पोनॅन्ट" instead of "घटक" on lines 156, 890, 892, 899 , 1500. Other than that It's a solid translation 😃

I have replaced घटक with कौम्पोनॅन्ट and I have committed the changes in my forked repo, now do i need to open a new PR or does the exisiting pr will have my new commit?
Also sorry for replying so late

@arshadkazmi42

Copy link
Copy Markdown
Member

hi @MayurSMahajan please use "कौम्पोनॅन्ट" instead of "घटक" on lines 156, 890, 892, 899 , 1500. Other than that It's a solid translation 😃

I have replaced घटक with कौम्पोनॅन्ट and I have committed the changes in my forked repo, now do i need to open a new PR or does the exisiting pr will have my new commit? Also sorry for replying so late

Your existing PR will have the new commits if you have done it on the same branch in your forked repo

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review till line 19.

Lets get these fixed, post these fixes we can continue on further review.

To know more about review process you can refer this ticket #23

Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Original : Components often need to change what's on the screen as a result of an interaction.
My Change : किसी क्रिया के परिणामस्वरूप कौम्पोनॅन्ट को अक्सर स्क्रीन पर जो कुछ भी है उसे बदलने की आवश्यकता होती है।
Requested : कोई भी इंटरेक्शन होने की वजह स कौम्पोनॅन्ट को अक्सर स्क्रीन पर क्या दिख रहा है उसको बदलना होता है।

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for working on the fixes.

I have added more review till line 910.

Let's get these fixed and then we can continue further.

Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added review comments for rest of the file.

Once these are fixed, we can get this merged

Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Comment threadbeta/src/pages/learn/state-a-components-memory.md Outdated
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience and working on all the fixes during the review process.

This is ready to be merged now.

Lets get this merged 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1st ReviewFirst phase of reviewbeta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MayurSMahajan@arshadkazmi42@yogesharma12