translation of choosing-the-state-structure page in Hindi by BrijenMakwana · Pull Request #221 · reactjs/hi.react.dev

BrijenMakwana · 2023-03-03T05:19:42Z

Translation of choosing-the-state-structure page in Hindi

Review Progress:

arshadkazmi42

Thank you for taking this up.

I have added review till line 102.

Lets get these fixed and post that we can continue with the review.
To know more about our review guides lines refer #23

BrijenMakwana · 2023-03-07T14:01:13Z

Thank you for taking this up.
I have added review till line 102.
Lets get these fixed and post that we can continue with the review. To know more about our review guides lines refer #23

I have made the changes that you have asked 👍🏻

arshadkazmi42

Thank you for working on the fixes.

I have added some more reviews till line 375.

Let's get these fixed and post that we can continue further with the review.

BrijenMakwana · 2023-03-08T12:35:22Z

Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.

I have made the changes 👍🏻

BrijenMakwana · 2023-03-19T12:17:53Z

Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.

@arshadkazmi42 Changes have been made, it's a request to provide a review 👍

arshadkazmi42

Added more reviews till line 818.

Lets get these fixed and then we can continue further.

BrijenMakwana · 2023-04-29T04:51:43Z

@arshadkazmi42 I have made the changes.

BrijenMakwana · 2023-05-27T04:41:58Z

@arshadkazmi42 My pull request is open for almost 3 months now. It's a request to provide a review soon so it can be merged.

arshadkazmi42 · 2023-05-27T10:41:17Z

@BrijenMakwana Thank you for the reminder and your patience. I am a bit busy and will be going through it soon.

arshadkazmi42

Thank you for working on the fixes.

I have added review to rest of the file, once these are fixed we can get this merged

BrijenMakwana · 2023-05-27T12:36:08Z

@arshadkazmi42 I have made all the changes. You can merge it. 😀

arshadkazmi42 · 2023-05-27T15:46:24Z

Thank you @BrijenMakwana for working on this. There seems to be a conflict. Can you fix those conflicts? post that we can get this merged.

arshadkazmi42 · 2023-05-28T07:34:31Z

@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file src/content/learn/choosing-the-state-structure.md

Let me know if you need any help with it.

BrijenMakwana · 2023-05-28T08:49:46Z

@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file src/content/learn/choosing-the-state-structure.md
Let me know if you need any help with it.

Sure. I'm working on it. Will let you know

BrijenMakwana · 2023-05-28T11:00:08Z

@arshadkazmi42 Please check if it can be merged now.

github-actions · 2023-05-28T13:03:39Z

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

arshadkazmi42 · 2023-05-28T13:05:34Z

Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.

BrijenMakwana · 2023-05-28T15:13:25Z

Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.

Thank you very much. I enjoyed working on it 🙂

github-actionsBot added the beta label Mar 3, 2023

vercelBotdeployed to Preview – hi.reactjs.org March 3, 2023 05:21 View deployment

vercelBotdeployed to Preview – hi-beta-reactjs-org March 3, 2023 05:21 View deployment

BrijenMakwana mentioned this pull request Mar 3, 2023
New Hindi Translation Progress #168
Open

BrijenMakwana closed this Mar 3, 2023

BrijenMakwana reopened this Mar 3, 2023

arshadkazmi42 assigned arshadkazmi42 and unassigned arshadkazmi42 Mar 7, 2023

arshadkazmi42 added the 1st Review First phase of review label Mar 7, 2023

arshadkazmi42 requested changes Mar 7, 2023
View reviewed changes

vercelBotdeployed to Preview – hi-beta-reactjs-org March 7, 2023 13:52 View deployment

vercelBotdeployed to Preview – hi.reactjs.org March 7, 2023 13:53 View deployment

BrijenMakwana requested a review from arshadkazmi42 March 8, 2023 10:57

arshadkazmi42 requested changes Mar 8, 2023
View reviewed changes

vercelBotdeployed to Preview – hi-beta-reactjs-org March 8, 2023 12:30 View deployment

vercelBotdeployed to Preview – hi.reactjs.org March 8, 2023 12:31 View deployment

BrijenMakwana requested a review from arshadkazmi42 March 8, 2023 12:35

arshadkazmi42 requested changes Apr 28, 2023
View reviewed changes

BrijenMakwana requested review from arshadkazmi42 April 29, 2023 04:52

arshadkazmi42 requested changes May 27, 2023
View reviewed changes

vercelBotdeployed to Preview May 28, 2023 03:32 View deployment

BrijenMakwana force-pushed the choosingTheStateStructureBrijen branch from aa85fe4 to 018e647Compare May 28, 2023 09:45

Brijen Makwanaand others added 5 commits May 28, 2023 16:15

translation of choosing-the-state-structure page in Hindi
569dbc4

review changes
32d75eb

review changes
a75b1be

review changes
894b6b6

last review changes
3fb8188

vercelBothad a problem deploying to Preview May 28, 2023 10:50 Failure

BrijenMakwana force-pushed the choosingTheStateStructureBrijen branch from 45bb7d3 to 3fb8188Compare May 28, 2023 10:54

vercelBotdeployed to Preview May 28, 2023 10:55 View deployment

arshadkazmi42 approved these changes May 28, 2023
View reviewed changes

arshadkazmi42 merged commit d4f887f into reactjs:mainMay 28, 2023

Uh oh!

Conversation

BrijenMakwana commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrijenMakwana commented Mar 7, 2023

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrijenMakwana commented Mar 8, 2023

Uh oh!

BrijenMakwana commented Mar 19, 2023

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrijenMakwana commented Apr 29, 2023

Uh oh!

BrijenMakwana commented May 27, 2023

Uh oh!

arshadkazmi42 commented May 27, 2023

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrijenMakwana commented May 27, 2023

Uh oh!

arshadkazmi42 commented May 27, 2023

Uh oh!

arshadkazmi42 commented May 28, 2023

Uh oh!

BrijenMakwana commented May 28, 2023

Uh oh!

BrijenMakwana commented May 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented May 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

Uh oh!

arshadkazmi42 commented May 28, 2023

BrijenMakwana commented Mar 3, 2023•
edited
Loading

BrijenMakwana commented May 28, 2023•
edited
Loading