Skip to content

referencing-values-with-refs translated in hindi - #229

Merged
arshadkazmi42 merged 6 commits into
reactjs:mainfrom
khizarq313:main
Aug 12, 2023
Merged

referencing-values-with-refs translated in hindi#229
arshadkazmi42 merged 6 commits into
reactjs:mainfrom
khizarq313:main

Conversation

@khizarq313

@khizarq313khizarq313 commented May 8, 2023

Copy link
Copy Markdown
Contributor

English to Hindi: Referencing values with refs #222

@khizarq313khizarq313 mentioned this pull request Jun 7, 2023
Open
@arshadkazmi42arshadkazmi42 added the 1st Review First phase of review label Jun 7, 2023
arshadkazmi42
arshadkazmi42 requested changes Jun 7, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I have added review till line 208. Let's get these fixes and then we can cotninue further with the review.

To know more about our review process you can refer #23

Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
@khizarq313

khizarq313 commented Jun 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Great work.

I have added review till line 208. Let's get these fixes and then we can cotninue further with the review.

To know more about our review process you can refer #23

Thanks for the review, I will correct my mistakes as soon as possible!

@khizarq313

khizarq313 commented Jun 9, 2023

Copy link
Copy Markdown
ContributorAuthor

I have fixed my translation mistakes, and I am very sorry for my silly mistakes, Please review further so that we get this done as fast as possible. Thank you! @arshadkazmi42 .

arshadkazmi42
arshadkazmi42 requested changes Aug 8, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the fixes.

I have added some more reviews till line 306.

Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
@khizarq313

khizarq313 commented Aug 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for working on the fixes.

I have added some more reviews till line 306.

Thank You!, I have fixed my mistakes. Lets move further!!

arshadkazmi42
arshadkazmi42 requested changes Aug 12, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this fixes.

I have added review for rest of the file. Once these are fixed we can get this merged.

Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
@khizarq313

khizarq313 commented Aug 12, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thank you for working on this fixes.

I have added review for rest of the file. Once these are fixed we can get this merged.

Thank you sir!
I have completed all the changes you mentioned above!

arshadkazmi42
arshadkazmi42 approved these changes Aug 12, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

Thank you for working on all the fixes.

Lets get this merged 🎉

@github-actions

github-actionsBot commented Aug 12, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42
arshadkazmi42 merged commit 118e6ff into reactjs:mainAug 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st ReviewFirst phase of review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khizarq313@arshadkazmi42