Skip to content

Translate State as a Snapshot - #236

Merged
arshadkazmi42 merged 9 commits into
reactjs:mainfrom
PriyankaBelhekar77:state-as-a-snapshot
May 12, 2024
Merged

Translate State as a Snapshot#236
arshadkazmi42 merged 9 commits into
reactjs:mainfrom
PriyankaBelhekar77:state-as-a-snapshot

Conversation

@PriyankaBelhekar77

@PriyankaBelhekar77PriyankaBelhekar77 commented Jun 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

I have translated the State as a Snapshot page. Please review it

@PriyankaBelhekar77

PriyankaBelhekar77 commented Jun 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@arshadkazmi42 please review it

@arshadkazmi42arshadkazmi42 added the 1st Review First phase of review label Jun 15, 2023
@arshadkazmi42

arshadkazmi42 commented Jun 15, 2023

Copy link
Copy Markdown
Member

Thank you for working on this. I will get to it asap.

@PriyankaBelhekar77

PriyankaBelhekar77 commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

@arshadkazmi42 please review it

arshadkazmi42
arshadkazmi42 requested changes Aug 8, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review till line 100.

Lets get these fixed and then we can continue further with the review.

Also, refer to our review guidelines #23

Comment threadsrc/content/learn/state-as-a-snapshot.md
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
@github-actions

github-actionsBot commented May 11, 2024•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 requested changes May 11, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comments till line 212.

Lets get these fixed and continue further

arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 requested changes May 11, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more till lines 313

@PriyankaBelhekar77
Update state-as-a-snapshot.md
62e6a64
review changes till line number 313
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 reviewed May 11, 2024
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
arshadkazmi42
arshadkazmi42 requested changes May 11, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making all the changes.

I have added review for rest of the file, once these are done we can get this merged 👍

arshadkazmi42
arshadkazmi42 approved these changes May 12, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @PriyankaBelhekar77

Thank you for making all the changes.

PR looks good now and we can get this merged.

@arshadkazmi42
arshadkazmi42 merged commit f3e16b3 into reactjs:mainMay 12, 2024
@arshadkazmi42arshadkazmi42 mentioned this pull request May 12, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st ReviewFirst phase of review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PriyankaBelhekar77@arshadkazmi42