Skip to content

translated-thinking-in-react - #239

Merged
arshadkazmi42 merged 10 commits into
reactjs:mainfrom
USKhokhar:thinking-in-react-hindi-translated
Sep 30, 2024
Merged

translated-thinking-in-react#239
arshadkazmi42 merged 10 commits into
reactjs:mainfrom
USKhokhar:thinking-in-react-hindi-translated

Conversation

@USKhokhar

@USKhokharUSKhokhar commented Jul 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Translated entire Thinking-in-react page in Hindi.

FILE: src/content/learn/thinking-in-react.md
URL: https://hi.react.dev/learn/thinking-in-react

@arshadkazmi42arshadkazmi42 added the 1st Review First phase of review label Jul 23, 2023
arshadkazmi42
arshadkazmi42 requested changes Aug 8, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review till line 56. Lets get these fixed then we can continue further with the review.

To know more about review guidelines refer #23

Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md

Start by drawing boxes around every component and subcomponent in the mockup and naming them. If you work with a designer, they may have already named these components in their design tool. Ask them!
* **सीएसएस** (CSS)--विचार करें कि आप class selectors किसके लिए बनाएँगे। (हालांकि, कंपोनेंट्स थोड़े कम सूक्ष्म होते हैं।)

@arshadkazmi42arshadkazmi42Aug 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line break

Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
@github-actions

github-actionsBot commented Sep 30, 2024•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42
arshadkazmi42 merged commit 57d7e14 into reactjs:mainSep 30, 2024
@arshadkazmi42arshadkazmi42 mentioned this pull request Nov 23, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st ReviewFirst phase of review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@USKhokhar@arshadkazmi42