Skip to content

Translated editor-setup page to hindi - #246

Merged
arshadkazmi42 merged 4 commits into
reactjs:mainfrom
Subramanyarao11:editor-setup
Oct 2, 2023
Merged

Translated editor-setup page to hindi#246
arshadkazmi42 merged 4 commits into
reactjs:mainfrom
Subramanyarao11:editor-setup

Conversation

@Subramanyarao11

@Subramanyarao11Subramanyarao11 commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@arshadkazmi42arshadkazmi42 added the 1st Review First phase of review label Aug 25, 2023
arshadkazmi42
arshadkazmi42 requested changes Sep 29, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review for few lines, once these are fixes this will be go to be merged.

Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
Comment threadsrc/content/learn/editor-setup.md Outdated
arshadkazmi42
arshadkazmi42 approved these changes Oct 2, 2023
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@github-actions

github-actionsBot commented Oct 2, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42
arshadkazmi42 merged commit a6af534 into reactjs:mainOct 2, 2023
@arshadkazmi42arshadkazmi42 mentioned this pull request Oct 2, 2023
Open
@Subramanyarao11

Subramanyarao11 commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Looks good. Thanks
Thank you so much for your thorough review and valuable suggestions! Your guidance was instrumental in getting this code merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st ReviewFirst phase of review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Subramanyarao11@arshadkazmi42