Skip to content

Update manipulating-the-dom-with-refs.md - #318

Merged
arshadkazmi42 merged 9 commits into
reactjs:mainfrom
MadDevMax:transalation-of-manuplating-dom
Dec 24, 2024
Merged

Update manipulating-the-dom-with-refs.md#318
arshadkazmi42 merged 9 commits into
reactjs:mainfrom
MadDevMax:transalation-of-manuplating-dom

Conversation

@MadDevMax

@MadDevMaxMadDevMax commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

translated manipulating dom page.

@MadDevMax
Update manipulating-the-dom-with-refs.md
d5d59a0
translated manipulating dom page.
arshadkazmi42
arshadkazmi42 requested changes Dec 24, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have left a few minor comments. Can you take a look at those. Post that we can get this merged.

Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
@MadDevMax
Update manipulating-the-dom-with-refs.md
cece967
reverted name translation of example
changed कंपोनेंट्स to कौम्पोनॅन्टस
also some minor changes
@MadDevMax
Update manipulating-the-dom-with-refs.md
c24b9f8
changed कंपोनेंट to कौम्पोनॅन्ट
@github-actions

github-actionsBot commented Dec 24, 2024•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

arshadkazmi42
arshadkazmi42 requested changes Dec 24, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the CI and it was throwing the same error. I did some debugging and found there were few heading links were removed which was causing the issue and that is the reason you were not able to commit.

I have left the comments to fix those. please double check if another heading is missing that.

Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
MadDevMaxand others added 3 commits December 24, 2024 18:13
@MadDevMax@arshadkazmi42
Update src/content/learn/manipulating-the-dom-with-refs.md
c3d5fb1
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
@MadDevMax@arshadkazmi42
Update src/content/learn/manipulating-the-dom-with-refs.md
1c66f06
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
@MadDevMax@arshadkazmi42
Update src/content/learn/manipulating-the-dom-with-refs.md
391d89c
Co-authored-by: Arshad Kazmi <arshadkazmi42@gmail.com>
@MadDevMax

MadDevMax commented Dec 24, 2024

Copy link
Copy Markdown
ContributorAuthor

@arshadkazmi42 heading issues are fixed now hopefully 🥲

arshadkazmi42
arshadkazmi42 approved these changes Dec 24, 2024
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@arshadkazmi42
arshadkazmi42 merged commit 10981d8 into reactjs:mainDec 24, 2024
@arshadkazmi42arshadkazmi42 mentioned this pull request Dec 24, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MadDevMax@arshadkazmi42@JugPatel