Skip to content

Translation of rendering-lists - #321

Merged
arshadkazmi42 merged 2 commits into
reactjs:mainfrom
vishnupprajapat:transalation-of-rendering-lists
Jan 27, 2025
Merged

Translation of rendering-lists#321
arshadkazmi42 merged 2 commits into
reactjs:mainfrom
vishnupprajapat:transalation-of-rendering-lists

Conversation

@vishnupprajapat

@vishnupprajapatvishnupprajapat commented Jan 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

New Hindi Translation Progress #168

@arshadkazmi42

Changes Proposed

Translation of rendering-lists

@vishnupprajapat

vishnupprajapat commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

New Hindi Translation Progress #168
@arshadkazmi42

@arshadkazmi42

arshadkazmi42 commented Jan 13, 2025

Copy link
Copy Markdown
Member

@vishnupprajapat Thank you for the PR. I will review it soon.

arshadkazmi42
arshadkazmi42 requested changes Jan 25, 2025
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Overall looks good 👍

I have left a few minor comments, can you fix those? Once those are fixed we can merge the PR.

Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
Comment threadsrc/content/learn/rendering-lists.md Outdated
vishnupprajapat
vishnupprajapat commented Jan 27, 2025
View reviewed changes

@vishnupprajapatvishnupprajapat left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshadkazmi42 I've fixed the minor comments you mentioned. Please review the changes

arshadkazmi42
arshadkazmi42 approved these changes Jan 27, 2025
View reviewed changes

@arshadkazmi42arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Thank you for making all the changes.

@github-actions

github-actionsBot commented Jan 27, 2025

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42
arshadkazmi42 merged commit 6f42e05 into reactjs:mainJan 27, 2025
@arshadkazmi42arshadkazmi42 mentioned this pull request Jan 25, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42arshadkazmi42arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vishnupprajapat@arshadkazmi42