Skip to content

Translate Tutorial Page - #10

Merged
gedeagas merged 7 commits into
reactjs:masterfrom
seikatsurugi:tr_tutorial
Feb 20, 2019
Merged

Translate Tutorial Page#10
gedeagas merged 7 commits into
reactjs:masterfrom
seikatsurugi:tr_tutorial

Conversation

@seikatsurugi

@seikatsurugiseikatsurugi commented Feb 10, 2019

Copy link
Copy Markdown

Hello guys! Finally manage to translate the tutorial page.

Kindly please review. Thank you

PS: I am not translating React terms like props and state and class names.

@seikatsurugiseikatsurugi mentioned this pull request Feb 10, 2019
Closed
96 tasks
@gedeagas

gedeagas commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

Awesome mas @martinock 🎉.

@regalius@arfianadam, let's review this.

regalius
regalius suggested changes Feb 10, 2019
View reviewed changes
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
Comment threadcontent/tutorial/tutorial.md Outdated
@seikatsurugi

seikatsurugi commented Feb 12, 2019

Copy link
Copy Markdown
Author

Thanks for the review, already fixed typos and revamp weird translations in the latest commit.

regalius
regalius suggested changes Feb 13, 2019
View reviewed changes
Comment threadcontent/tutorial/tutorial.md Outdated
@tesseralis

tesseralis commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

@regalius is this ready to be merged in?

gedeagas
gedeagas approved these changes Feb 20, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tesseralis this is good to go.

Thank you for contributing @martinock

@gedeagas
gedeagas merged commit 64c2de3 into reactjs:masterFeb 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arfianadamarfianadamAwaiting requested review from arfianadam
2 more reviewers
@regaliusregaliusregalius approved these changes
@gedeagasgedeagasgedeagas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seikatsurugi@gedeagas@tesseralis@regalius