Skip to content

Translate Warnings/unknown-prop - #104

Merged
resir014 merged 2 commits into
reactjs:masterfrom
ismailnagib:warnings/unknown-prop
Oct 4, 2019
Merged

Translate Warnings/unknown-prop#104
resir014 merged 2 commits into
reactjs:masterfrom
ismailnagib:warnings/unknown-prop

Conversation

@ismailnagib

Copy link
Copy Markdown
Contributor

Dear maintainers, please review the changes I've proposed in the PR and give me feedback. Thank you.

@netlify

netlifyBot commented Sep 26, 2019

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit d731153

https://deploy-preview-104--idreactjs.netlify.com

@netlify

netlifyBot commented Sep 26, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit d731153

https://deploy-preview-104--id-reactjs.netlify.com

@ismailnagibismailnagib changed the title add translation for warnings/unknown-propTranslate Warnings/Unknown-PropSep 27, 2019

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help @ismailnagib!

Just one more thing, please update the PR to use the correct form of "Anda" (capitalised) before I can merge. 😄

@ismailnagib

Copy link
Copy Markdown
ContributorAuthor

I've submitted the requested changes. Thank you for the feedback! @resir014

@resir014resir014 changed the title Translate Warnings/Unknown-PropTranslate Warnings/unknown-propOct 4, 2019

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your help! ❤️

@resir014
resir014 merged commit eb54b3b into reactjs:masterOct 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ismailnagib@resir014